From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Magne Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: EMACS_INT cleanup Date: Fri, 24 Sep 2010 15:23:16 +0200 Organization: Programmerer Ingebrigtsen Message-ID: References: <83aan8uvy3.fsf@gnu.org> <8339t0uthi.fsf@gnu.org> <831v8kurwd.fsf@gnu.org> <83wrqctcha.fsf@gnu.org> <83vd5wtc7j.fsf@gnu.org> <83bp7ntosd.fsf@gnu.org> <83aan7tksh.fsf@gnu.org> <838w2rthil.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1285334640 17236 80.91.229.12 (24 Sep 2010 13:24:00 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 24 Sep 2010 13:24:00 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 24 15:23:55 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Oz8Fl-0004Jr-S3 for ged-emacs-devel@m.gmane.org; Fri, 24 Sep 2010 15:23:54 +0200 Original-Received: from localhost ([127.0.0.1]:48495 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oz8Fl-0006D9-9X for ged-emacs-devel@m.gmane.org; Fri, 24 Sep 2010 09:23:53 -0400 Original-Received: from [140.186.70.92] (port=39187 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oz8FW-00068v-1O for emacs-devel@gnu.org; Fri, 24 Sep 2010 09:23:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oz8FQ-0005by-Pj for emacs-devel@gnu.org; Fri, 24 Sep 2010 09:23:37 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:50231) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oz8FQ-0005bN-Ds for emacs-devel@gnu.org; Fri, 24 Sep 2010 09:23:32 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1Oz8FO-00046j-16 for emacs-devel@gnu.org; Fri, 24 Sep 2010 15:23:30 +0200 Original-Received: from cm-84.215.34.171.getinternet.no ([84.215.34.171]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 24 Sep 2010 15:23:30 +0200 Original-Received: from larsi by cm-84.215.34.171.getinternet.no with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 24 Sep 2010 15:23:30 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 47 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: cm-84.215.34.171.getinternet.no Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEUgBAEiBQK6L2VYGiQc AwAuDg4kBwZVlQh1AAACdUlEQVQ4jV2Uy5LqIBCGG6OuQUvWM1DjWulD1qkyM2uVIutgKrz/I5xu wKo5hyov9Ad/XxMI+F7OGGPfGw+xLSy24KOv+wr4Ghn6dZkw5GlaCeS85owrLt4nxAU9PjTZGOSs XqjQe4859l97VGyDnJRSx8cp2B07+RPmUwNZKXnso3cR8Rv7LsL7hpByH66eAxgRe38Xqd2QAN6f WGgMFOAWQFcAsL34GwYM4+KxH0Hp5hxgwejR38YQnvehOIGZgFBH33tU3z+52wNIwUCwE3WMQdph xPEGBKpUniiR6Yngrjc7dhcJqkjFnIUSiCahsX5vVpSygQRqcJYqbszZmYOV9cZEmavhxM0gSh3p aV99aIpX0HEy0gfJLnVeCXAVlUO2GtefybnMBVAeAg7XCroPChd06QdnDpvPKna4CCpdbVSpSWdf T7J/uDtwSRgkEgLYmwMFZr2h/xxukRJUeGGiccYdKYsCyHkiqSylm8/GhOVL0rkG1Cz0DC/PUuZT ipIgAyoBeQ9hQ9nZnrpEQLcpUVJuTOB4z2KmbdZ1Spjs+Lwxk6aDSTcAnGIBls4I+UuK6vAy1hku iGg+ihbd6BjcoSSoStlLSQB23Cr6FVBvTFWJiuLsREBwHhQWtVZLtoNwfrEDcOZSa91GlKW4u9yl kjmBJjV0B2fxSkKy1Uo1IjZPeykbHpL1nTmRZzp+Qp2dHGtrq5d+C1iS0DkWoFOSNAC48/Q432s3 CqhFOdG8WWseZdoYxKkSAjxwj+K7vADYFT8jKepE4Qu1r8BPOelEg7LdDgDjSF+qST0G2I6/F5Se xzjN4/9r1it4fqj/vTH+kJe/wQLYGsxREcYAAAAASUVORK5CYII= Mail-Copies-To: never X-Now-Playing: Boris's _Smile (Live in Prague)_: "You Were Holding An Unbrella" User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:eVh6UvJQ/FuV3E0f2EB1hFhL1Os= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:130769 Archived-At: Eli Zaretskii writes: >> since -Wall is in the state it's in, I was assuming that there might >> be a reason for that state. > > Lazyness^H^H^H^H^H^Hck of time? Right. :-) I'll continue the -Wconversion trolling in the Emacs sources, and fix all the long->int conversions I find, no matter how unlikely it is to appear in real life, then. But probably not tonight. If somebody else wants to join in, feel free. They methodology I'm using is the following: 1) First I say "make" as normal in the src directly. 2) Then I alter the warnings switch to add -Wconversion: C_WARNINGS_SWITCH = -Wimplicit-function-declaration -Wold-style-definition -Wdeclaration-after-statement -Wno-pointer-sign -Wconversion 3) Then I pick a file -- for instance, fns.c. Then I force-save it to update the time stamp. 4) Then I hit F7, which I have bound to: (global-set-key [f7] (lambda () (interactive) (save-some-buffers t) (ignore-errors (mapcar (lambda (proc) (kill-process proc)) compilation-in-progress)) (setq compilation-in-progress nil) (compile "make -k 2>&1 | egrep \"(conversion.*'int'.*(Lisp_Obj|long)|error)\""))) So then it's only a case of next-erroring to each error and fix stuff. Anyone can do it! :-) (If they have gcc 4.4.) -- (domestic pets only, the antidote for overdose, milk.) larsi@gnus.org * Lars Magne Ingebrigtsen