Re: [Emacs-diffs] master 43cc5d8: Make `q' etc work in image mode again

Re: [Emacs-diffs] master 43cc5d8: Make `q' etc work in image mode again

[Stefan Monnier]

> -  (let ((map (make-sparse-keymap)))
> +  (let ((map (copy-keymap image-map)))
>      (set-keymap-parent map special-mode-map)
> -    (set-keymap-parent map image-map)

We should avoid using copy-keymap.  If you want multiple-inheritance, we
have it now: use make-composed-keymap.


        Stefan

Re: [Emacs-diffs] master 43cc5d8: Make `q' etc work in image mode again

[Lars Magne Ingebrigtsen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> We should avoid using copy-keymap.  If you want multiple-inheritance, we
> have it now: use make-composed-keymap.

Ah, great.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: [Emacs-diffs] master 43cc5d8: Make `q' etc work in image mode again

[Lars Magne Ingebrigtsen]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>> We should avoid using copy-keymap.  If you want multiple-inheritance, we
>> have it now: use make-composed-keymap.
>
> Ah, great.

Uhm...  something weird happened.  Now all the image mode commands are
bound in the image-map keymap?  

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: [Emacs-diffs] master 43cc5d8: Make `q' etc work in image mode again

[Lars Magne Ingebrigtsen]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
>
>> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>
>>> We should avoid using copy-keymap.  If you want multiple-inheritance, we
>>> have it now: use make-composed-keymap.
>>
>> Ah, great.
>
> Uhm...  something weird happened.  Now all the image mode commands are
> bound in the image-map keymap?  

Ah, that's not how you're suppose to call that function, because if you
modify the map afterwards, they ... happen in the first of the composed
maps?  Kinda confusing.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: [Emacs-diffs] master 43cc5d8: Make `q' etc work in image mode again

[Stefan Monnier]

> Ah, that's not how you're suppose to call that function, because if you
> modify the map afterwards, they ... happen in the first of the composed
> maps?  Kinda confusing.

Yes, it's a quirk that's hard to avoid because key lookup can return such
a composed keymap, and define-key uses that same key lookup after which
it needs to find the actual submap to modify.


        Stefan