From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.bugs Subject: bug#35645: Fix icalendar--add-diary-entry/diary-make-entry interaction Date: Fri, 07 Jun 2019 21:36:10 -0400 Message-ID: References: <874l5xhp0e.fsf@gmail.com> <87r28a4j4a.fsf@panama> <83a7etrbsr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="204161"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35645-done@debbugs.gnu.org, npostavs@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 08 03:37:54 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hZQIr-000qyn-Rm for geb-bug-gnu-emacs@m.gmane.org; Sat, 08 Jun 2019 03:37:54 +0200 Original-Received: from localhost ([::1]:54728 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZQIq-0006uG-BV for geb-bug-gnu-emacs@m.gmane.org; Fri, 07 Jun 2019 21:37:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40390) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZQI9-0006u3-DY for bug-gnu-emacs@gnu.org; Fri, 07 Jun 2019 21:37:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hZQI4-0007b9-QP for bug-gnu-emacs@gnu.org; Fri, 07 Jun 2019 21:37:09 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39098) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hZQI2-0007a2-Sh for bug-gnu-emacs@gnu.org; Fri, 07 Jun 2019 21:37:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hZQI2-0000Fr-Ou for bug-gnu-emacs@gnu.org; Fri, 07 Jun 2019 21:37:02 -0400 Resent-From: Thomas Fitzsimmons Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Jun 2019 01:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 35645 X-GNU-PR-Package: emacs Mail-Followup-To: 35645@debbugs.gnu.org, fitzsim@fitzsim.org, fitzsim@fitzsim.org Original-Received: via spool by 35645-done@debbugs.gnu.org id=D35645.1559957780924 (code D ref 35645); Sat, 08 Jun 2019 01:37:02 +0000 Original-Received: (at 35645-done) by debbugs.gnu.org; 8 Jun 2019 01:36:20 +0000 Original-Received: from localhost ([127.0.0.1]:52640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZQHL-0000Ep-Ou for submit@debbugs.gnu.org; Fri, 07 Jun 2019 21:36:20 -0400 Original-Received: from mail-it1-f174.google.com ([209.85.166.174]:56005) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZQHJ-0000Ed-Ul for 35645-done@debbugs.gnu.org; Fri, 07 Jun 2019 21:36:18 -0400 Original-Received: by mail-it1-f174.google.com with SMTP id i21so5452598ita.5 for <35645-done@debbugs.gnu.org>; Fri, 07 Jun 2019 18:36:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=k8eGsYYimDl4+z/t33iF9LByAWu+8RLeqoJezdiCf/E=; b=bPSgc+6nIrbT9DhcmdWhah3n+AtIf/6UTKT0zWg6L3wIyNHrWXE18CP0/p6h/v2vQw PywRDtX4sf9xbk4pTHzLMtprY4bVpZREU9ono0iMLPKm46fFcOZ2dbNTZkOdIX+dZPlA m8wkPnrwavQQfXd2QY8ra9aMZZLj7f3TCoLDjE6JQJ5bhZNL6i4VntePW/5CfKrcvvE2 TQ0wlbV5c+h9d7YVfY4kV9vxW/h2PbmKDrL6ig0euCKKWpB0F4rQhD67/k7J+0pFHugl nScYHBn72Qjyxg0uyO3QBuJvH5pvSDbgbfFgAbnOX2vuSxm9cv9kMFSnKEPHFyI7n5X3 WGhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=k8eGsYYimDl4+z/t33iF9LByAWu+8RLeqoJezdiCf/E=; b=Vh6bes/5gR9Klda37S4fBQHZu7Jw+nLG3KOnTJzKm017ZMLDzyCvuXxEe6IS9hh2aN QSp5M4OBsDj2nROn/MCnxFhqCCjuhT/hRgnkFC/Jp16+CK7s+7gw0ju2eipoQvNNMlqQ VwwOSjdEvJaN2+VqBdX+bBe8l0mxlyLH1ATzG8ZJhKg/oalkDCgv5vsjitorEDqQLllD sbDkQh9OWJUnN3fRtC8mkqRpG7HPOAGqATiD/nlr2scjVLMnkyBKuVZCWOpARLhz/b81 HxuQ/FxijYWRL0KLUYq1Yg2j8HYAlDyEK5mWan5GXMoLdItqkkIUVq3YZ/M09vGq+8hN ySYg== X-Gm-Message-State: APjAAAXuydxTyubUg2QQlCqpS3OnjNxG8HmdIxciAXFp/qjvL7dn2k9P 1UvcdhL4TQtmmrCThVQpKZosoA== X-Google-Smtp-Source: APXvYqxDfwpZ9kIpQzmqkppJGGhp7b8L3MrLpWAthWySCeaWy9Z+2+tPOaBdBWmLJuAl4I+/cp+XGA== X-Received: by 2002:a24:9b83:: with SMTP id o125mr5255200itd.127.1559957772184; Fri, 07 Jun 2019 18:36:12 -0700 (PDT) Original-Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id j13sm1266456ioa.76.2019.06.07.18.36.11 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Fri, 07 Jun 2019 18:36:11 -0700 (PDT) In-Reply-To: (Thomas Fitzsimmons's message of "Fri, 07 Jun 2019 08:37:18 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160225 Archived-At: Thomas Fitzsimmons writes: > Eli Zaretskii writes: > >>> From: Ulf Jasper >>> Date: Mon, 03 Jun 2019 20:30:13 +0200 >>> Cc: 35645@debbugs.gnu.org, Noam Postavsky >>> >>> Am 23.05.2019 um 22:49 (-0400) schrieb Thomas Fitzsimmons: >>> > >>> > Ulf, the only other feedback I have for icalendar is that >>> > icalendar--add-diary-entry is useful to/used by other packages (e.g., >>> > Excorporate) despite it being a private function. What if we added a >>> > public alias, icalendar-add-diary-entry, within this same patch? Then I >>> > could check for that alias's existence and only enable the workaround >>> > advice for older Emacs versions. >>> > >>> >>> Could you please provide a patch with all the changes we want to make? >> >> Ping! Thomas, could you please provide a patch as Ulf requested? We >> would like to proceed with fixing this issue. > > I tried out this approach, mostly to try to preserve > icalendar--add-diary-entry's current default behaviour of showing the > resulting diary buffer. However, I was wrong about > icalendar-add-diary-entry being called directly; the icalendar entry > point Excorporate calls is icalendar-import-buffer. So I think the > original patch is fine as-is, as long as Ulf is OK with the change to > icalendar--add-diary-entry's default behaviour, such that it does not > show the modified diary file's buffer (which some third party packages > might rely on). To determine whether or not to apply the workarounds > I'll check the "arity" of diary-make-entry. > > I'll write the change log and push the patch this evening unless I hear > otherwise. I pushed the fix to master. Thomas