all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: William Xu <william.xwl@gmail.com>, 11605@debbugs.gnu.org
Subject: bug#11605: 24.1.50; vc-ediff revert annoyance
Date: Thu, 27 Jun 2019 17:16:21 +0200	[thread overview]
Message-ID: <m3woh75a9m.fsf@gnus.org> (raw)
In-Reply-To: <14f8969f-2d5a-e2c3-50e3-5201425be6fd@yandex.ru> (Dmitry Gutov's message of "Fri, 26 Feb 2016 02:38:35 +0200")

Dmitry Gutov <dgutov@yandex.ru> writes:

>>>        (with-current-buffer result-buf
>>>  	;; Set the parent buffer so that things like
>>>  	;; C-x v g, C-x v l, ... etc work.
>>> -	(set (make-local-variable 'vc-parent-buffer) filebuf))
>>> +	(set (make-local-variable 'vc-parent-buffer) filebuf)
>>> +        (revert-buffer nil t))
>
> It seems like this might conflict with other uses of vc-find-revision,
> like vc-revision-other-window. Where the user is allowed to change the
> contents of the returned buffer, and might've done so before we do
> this automatic silent revert.
>
> Maybe do it on ediff's side instead?

Yeah, after poking at this a bit more, I agree -- ediff should set up
this better, and just calling revert in the vc functions does not seem
to be the logical choice.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





      parent reply	other threads:[~2019-06-27 15:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-02  4:31 bug#11605: 24.1.50; vc-ediff revert annoyance William Xu
2016-02-24  6:33 ` Lars Ingebrigtsen
2016-02-26  0:38   ` Dmitry Gutov
2016-02-26  6:01     ` Lars Ingebrigtsen
2016-02-26 10:36       ` Dmitry Gutov
2016-02-26  9:38     ` William Xu
2016-02-26 10:10       ` Dmitry Gutov
2019-06-27 15:16     ` Lars Ingebrigtsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3woh75a9m.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=11605@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=william.xwl@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.