From: Thomas Fitzsimmons <fitzsim@fitzsim.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Alain Picard <alain@gocatch.com>, 24490@debbugs.gnu.org
Subject: bug#24490: 25.1; restclient no longer sends auth header upon redirect
Date: Wed, 14 Jul 2021 13:47:36 -0400 [thread overview]
Message-ID: <m3wnpsokhz.fsf@fitzsim.org> (raw)
In-Reply-To: <m3y2agqylg.fsf@fitzsim.org> (Thomas Fitzsimmons's message of "Thu, 08 Jul 2021 17:34:19 -0400")
Thomas Fitzsimmons <fitzsim@fitzsim.org> writes:
> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> Alain Picard <alain@gocatch.com> writes:
>>
>>> Dear Maintainers,
>>>
>>> In emacs 25.1,
>>> the code in url-http.el, line 638, states:
>>>
>>> ;; Do not automatically include an authorization header in the
>>> ;; redirect. If needed it will be regenerated by the relevant
>>> ;; auth scheme when the new request happens.
>>> (setq url-http-extra-headers
>>> (cl-remove "Authorization"
>>> url-http-extra-headers :key 'car :test 'equal))
>>>
>>> I suspect this automatic regenration does not occur.
>>
>> I think this code is basically correct -- if the auth scheme has added
>> something to url-http-extra-headers, then that has to be removed when
>> doing the redirect, because otherwise we might be sending the auth to a
>> completely wrong server, with the security implications of that.
>>
>>> Problem: I am using restclient.el, and hitting a server which
>>> issues a redirect, and I receive a 400 Forbidden response because
>>> the redirected call does not receive the authentication header
>>> (I can see this from the log of my server).
>>
>> I think this must be a bug in restclient.el -- it should instead use an
>> auth scheme that re-adds the Authorization header.
>
> It looks like restclient.el uses advice to skip
> url-http-handle-authentication if it (restclient) is in the middle of a
> request.
>
> Alain, to rule out that advice as being responsible, can you do:
>
> M-: (ad-deactivate 'url-http-handle-authentication)
>
> then try the API call again?
The email to "alain@gocatch.com" bounced, so I think we should probably
close this bug report.
Thomas
next prev parent reply other threads:[~2021-07-14 17:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 4:19 bug#24490: 25.1; restclient no longer sends auth header upon redirect Alain Picard
2016-09-21 8:15 ` Andreas Schwab
2016-09-22 0:01 ` Alain Picard
2021-07-06 15:44 ` Lars Ingebrigtsen
2021-07-08 21:34 ` Thomas Fitzsimmons
2021-07-14 17:47 ` Thomas Fitzsimmons [this message]
2021-07-14 18:23 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3wnpsokhz.fsf@fitzsim.org \
--to=fitzsim@fitzsim.org \
--cc=24490@debbugs.gnu.org \
--cc=alain@gocatch.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.