From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Pavel@Janik.cz (Pavel =?iso-8859-2?q?Jan=EDk?=) Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] Changes to emacs/lisp/ChangeLog Date: Mon, 01 Apr 2002 11:12:05 +0200 Sender: emacs-devel-admin@gnu.org Message-ID: References: <200203311640.g2VGeFw10733@aztec.santafe.edu> NNTP-Posting-Host: localhost.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable X-Trace: main.gmane.org 1017652546 28585 127.0.0.1 (1 Apr 2002 09:15:46 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 1 Apr 2002 09:15:46 +0000 (UTC) Cc: emacs-devel@gnu.org Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.33 #1 (Debian)) id 16rxuk-0007Qw-00 for ; Mon, 01 Apr 2002 11:15:46 +0200 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 16ry5s-0006xz-00 for ; Mon, 01 Apr 2002 11:27:16 +0200 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian)) id 16rxrA-0006Z3-00; Mon, 01 Apr 2002 04:12:04 -0500 Original-Received: from p0042.as-l043.contactel.cz ([194.108.242.42] helo=SnowWhite.SuSE.cz) by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian)) id 16rxqt-0006YJ-00; Mon, 01 Apr 2002 04:11:47 -0500 Original-Received: by SnowWhite.SuSE.cz (PJ, from userid 500) id E73F419198; Mon, 1 Apr 2002 11:14:02 +0200 (CEST) Original-To: rms@gnu.org Mail-Copies-To: never X-Face: $"d&^B_IKlTHX!y2d,3;grhwjOBqOli]LV`6d]58%5'x/kBd7.MO&n3bJ@Zkf&RfBu|^qL+ ?/Re{MpTqanXS2'~Qp'J2p^M7uM:zp[1Xq#{|C!*'&NvCC[9!|=>#qHqIhroq_S"MH8nSH+d^9*BF: iHiAs(t(~b#1.{w.d[=Z In-Reply-To: <200203311640.g2VGeFw10733@aztec.santafe.edu> (Richard Stallman's message of "Sun, 31 Mar 2002 09:40:15 -0700 (MST)") User-Agent: Gnus/5.090006 (Oort Gnus v0.06) Emacs/21.2.50 (i386-suse-linux-gnu) Original-Lines: 32 Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.8 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:2298 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:2298 [ Redirected to emacs-devel. ] From: Richard Stallman Date: Sun, 31 Mar 2002 09:40:15 -0700 (MST) > Richard, play-sound is not guaranteed to exist. >=20 > Yes, I saw that. >=20 > So it is not safe to make play-sound-file unconditional (we can re= move > XEmacs comment though). >=20 > It seems safe to me. If play-sound is not defined, play-sound-file > will get an error trying to call it. I think that is cleaner behavior > than what happens if play-sound-file is not defined at all. I think it would be much cleaner to: - Fprovide (intern ("sound"), Qnil) in sound.c when `play-sound' is defined - use (featurep 'sound) to check if `play-sound' is defined and if it is not, provide meaningful error message to the user telling him that his Emacs was compiled without sound support I can do that if you agree with this. I will also add --with[out]-sound to configure. --=20 Pavel Jan=EDk panic("Detected a card I can't drive - whoops\n"); -- 2.2.16 drivers/net/daynaport.c