From: Pavel@Janik.cz (Pavel Janík)
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] Changes to emacs/lisp/ChangeLog
Date: Mon, 01 Apr 2002 11:12:05 +0200 [thread overview]
Message-ID: <m3vgbbye8q.fsf@Janik.cz> (raw)
In-Reply-To: <200203311640.g2VGeFw10733@aztec.santafe.edu> (Richard Stallman's message of "Sun, 31 Mar 2002 09:40:15 -0700 (MST)")
[ Redirected to emacs-devel. ]
From: Richard Stallman <rms@gnu.org>
Date: Sun, 31 Mar 2002 09:40:15 -0700 (MST)
> Richard, play-sound is not guaranteed to exist.
>
> Yes, I saw that.
>
> So it is not safe to make play-sound-file unconditional (we can remove
> XEmacs comment though).
>
> It seems safe to me. If play-sound is not defined, play-sound-file
> will get an error trying to call it. I think that is cleaner behavior
> than what happens if play-sound-file is not defined at all.
I think it would be much cleaner to:
- Fprovide (intern ("sound"), Qnil) in sound.c when `play-sound' is defined
- use (featurep 'sound) to check if `play-sound' is defined and if it is
not, provide meaningful error message to the user telling him that his
Emacs was compiled without sound support
I can do that if you agree with this. I will also add --with[out]-sound to
configure.
--
Pavel Janík
panic("Detected a card I can't drive - whoops\n");
-- 2.2.16 drivers/net/daynaport.c
next parent reply other threads:[~2002-04-01 9:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E16r5bQ-0001Jp-00@subversions.gnu.org>
[not found] ` <m3vgbe5wjm.fsf@Janik.cz>
[not found] ` <200203311640.g2VGeFw10733@aztec.santafe.edu>
2002-04-01 9:12 ` Pavel Janík [this message]
2002-04-01 10:19 ` [Emacs-diffs] Changes to emacs/lisp/ChangeLog Eli Zaretskii
2002-04-01 15:05 ` Stefan Monnier
2002-04-01 17:02 ` Pavel Janík
2002-04-01 23:21 ` Richard Stallman
2002-04-02 17:09 ` Pavel Janík
2002-04-03 22:50 ` Richard Stallman
[not found] <E1FiEqb-0007QY-IW@savannah.gnu.org>
2006-05-23 12:07 ` Michaël Cadilhac
2006-05-23 14:39 ` Stefan Monnier
2006-05-23 17:14 ` Michaël Cadilhac
2006-05-23 20:51 ` Stefan Monnier
2006-05-24 8:48 ` Michaël Cadilhac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3vgbbye8q.fsf@Janik.cz \
--to=pavel@janik.cz \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.