Changes to gdb-ui.el

Changes to gdb-ui.el

[Nick Roberts]

I don't think using breakpoint faces in text-mode quite works. On a basic
xterm, an enabled breakpoint (letter 'B') stands out clearly in red, but
as disabled breakpoint (letter 'b') disappears completely. I don't understand
the subtleties of faces but maybe grey60 gets 'rounded' to white on an xterm
with 8/16 colours. Also the background of the face doesn't always match the
background of the terminal (I have found particularly so for a gnome-terminal).

In X, enabled/disabled breakpoints are distinguished by colour alone, the
icons having the same shape both in the margin and in the fringe. In text
mode the breakpoint state is already distinguished by the case of the letter
(B/b) so the same colour can be used. To help it stand out from the text,
I guess this color could be red in both cases, a color which I presume is
available on many terminals.

Nick

Re: Changes to gdb-ui.el

[Miles Bader]

On Mon, 21 Mar 2005 11:03:10 +1200, Nick Roberts <nickrob@snap.net.nz> wrote:
> I don't think using breakpoint faces in text-mode quite works. On a basic
> xterm, an enabled breakpoint (letter 'B') stands out clearly in red, but
> as disabled breakpoint (letter 'b') disappears completely.

It works correclty on the linux console; it may be face definitions
need tweaking for "low-color" terminals (this can be done using the
conditional facility of the face definition language).

> the subtleties of faces but maybe grey60 gets 'rounded' to white on an xterm
> with 8/16 colours.

Yes, this is probably what's happening.

> Also the background of the face doesn't always match the
> background of the terminal (I have found particularly so for a gnome-terminal).

Ok; probably the `:inherit fringe' should be used only for bitmaps (is
it even useful for them?  I though fringe stuff would get merged with
the fringe face anyway).

> In X, enabled/disabled breakpoints are distinguished by colour alone, the
> icons having the same shape both in the margin and in the fringe. In text
> mode the breakpoint state is already distinguished by the case of the letter
> (B/b) so the same colour can be used. To help it stand out from the text,
> I guess this color could be red in both cases, a color which I presume is
> available on many terminals.

Note that I made this change because I was setting breakpoints on a
tty and couldn't see them very well; having them displayed in bold red
_really_ helps.

I'll give the faces a tweak to reflect the above points.

-Miles
-- 
Do not taunt Happy Fun Ball.

Re: Changes to gdb-ui.el

[Richard Stallman]

    I don't think using breakpoint faces in text-mode quite works.

You're the main GUD hacker now.  If you don't like the change that was
installed in gdb-ui.el, please don't argue--please take it out.  If
you think it is ok but some details need tweaking, please do that.

Re: Changes to gdb-ui.el

[Nick Roberts]

 >     I don't think using breakpoint faces in text-mode quite works.
 > 
 > You're the main GUD hacker now.  If you don't like the change that was
 > installed in gdb-ui.el, please don't argue--please take it out.  If
 > you think it is ok but some details need tweaking, please do that.

I am just describing the shortcomings so that Miles can tweak the code. He
knows more about faces than I do.

Nick

Re: Changes to gdb-ui.el

[Miles Bader]

I've changed the faces, so I think they should now handle all the
various cases correctly.  I with both light and dark backgrounds, and
both a graphic display and gnome-terminal.

One thing I wonder about -- when displaying something in the fringe on
a graphic display you must :inherit `fringe' to get the background
correct (otherwise it uses the `default' background); shouldn't
redisplay merge any face used in the fringe withh the `fringe' face
during display?

-Miles
-- 
Do not taunt Happy Fun Ball.

Re: Changes to gdb-ui.el

[Richard Stallman]

    One thing I wonder about -- when displaying something in the fringe on
    a graphic display you must :inherit `fringe' to get the background
    correct (otherwise it uses the `default' background); shouldn't
    redisplay merge any face used in the fringe withh the `fringe' face
    during display?

I think that would be more correct.

Re: Changes to gdb-ui.el

[Kim F. Storm]

Richard Stallman <rms@gnu.org> writes:

>     One thing I wonder about -- when displaying something in the fringe on
>     a graphic display you must :inherit `fringe' to get the background
>     correct (otherwise it uses the `default' background); shouldn't
>     redisplay merge any face used in the fringe withh the `fringe' face
>     during display?
>
> I think that would be more correct.

Done.

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk