Re: File modes facilities.

[storm@cua.dk (Kim F. Storm)]

Michael Cadilhac <michael.cadilhac@lrde.epita.fr> writes:

> "Richard M. Stallman" <rms@gnu.org> writes:
>
>> There IS a function called set-file-modes.  It is not interactive.  My
>> idea is to rename that to set-file-modes-internal, and use your chmod
>> command under the name set-file-modes.  It should accept a numeric
>> mode argument too; that way, existing callers will still work.  It
>> would use file-modes-to-number.

I still think my approach to make any command interactive is much, much
better (and simpler) than this hotch-potch approach of renamingbuilt-in
functions to COMMAND-internal and provide a wrapper in Lisp.

BTW, I thought RMS said he didn't want to include this feature before
the release!??!?

That said, is it really safe to change the name of the file handler
for set-file-modes?  Will it break tramp and ange-ftp (and ???)



> ***************
> *** 3476,3484 ****
>   
>     /* If the file name has special constructs in it,
>        call the corresponding file handler.  */
> !   handler = Ffind_file_name_handler (absname, Qset_file_modes);
>     if (!NILP (handler))
> !     return call3 (handler, Qset_file_modes, absname, mode);
>   
>     encoded_absname = ENCODE_FILE (absname);
>   
> --- 3478,3486 ----
>   
>     /* If the file name has special constructs in it,
>        call the corresponding file handler.  */
> !   handler = Ffind_file_name_handler (absname, Qset_file_modes_internal);
>     if (!NILP (handler))
> !     return call3 (handler, Qset_file_modes_internal, absname, mode);
>   
>     encoded_absname = ENCODE_FILE (absname);

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk