From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: C-g crash redux Date: Sat, 05 Aug 2006 01:35:03 +0200 Message-ID: References: <877j1qvp4k.fsf@pacem.orebokech.com> <17617.8764.824445.882539@kahikatea.snap.net.nz> <87fygd97j0.fsf@stupidchicken.com> <87zmelfihg.fsf@stupidchicken.com> <877j1owmhx.fsf@stupidchicken.com> <874pwsebes.fsf@stupidchicken.com> <17619.50473.875843.483875@kahikatea.snap.net.nz> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1154734633 23766 80.91.229.2 (4 Aug 2006 23:37:13 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 4 Aug 2006 23:37:13 +0000 (UTC) Cc: Chong Yidong , Romain Francoise , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Aug 05 01:37:09 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1G99Dy-0007FG-QZ for ged-emacs-devel@m.gmane.org; Sat, 05 Aug 2006 01:37:03 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1G99Dy-0007va-7U for ged-emacs-devel@m.gmane.org; Fri, 04 Aug 2006 19:37:02 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1G99Dl-0007us-46 for emacs-devel@gnu.org; Fri, 04 Aug 2006 19:36:49 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1G99Dh-0007sc-Ri for emacs-devel@gnu.org; Fri, 04 Aug 2006 19:36:48 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1G99Dh-0007sY-OP for emacs-devel@gnu.org; Fri, 04 Aug 2006 19:36:45 -0400 Original-Received: from [195.41.46.235] (helo=pfepa.post.tele.dk) by monty-python.gnu.org with esmtp (Exim 4.52) id 1G99HM-00042i-Po for emacs-devel@gnu.org; Fri, 04 Aug 2006 19:40:32 -0400 Original-Received: from kfs-l.imdomain.dk.cua.dk (0x503e2644.bynxx3.adsl-dhcp.tele.dk [80.62.38.68]) by pfepa.post.tele.dk (Postfix) with SMTP id 2F933FAC033; Sat, 5 Aug 2006 01:36:32 +0200 (CEST) Original-To: Nick Roberts In-Reply-To: <17619.50473.875843.483875@kahikatea.snap.net.nz> (Nick Roberts's message of "Sat, 5 Aug 2006 10:07:37 +1200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:58108 Archived-At: Nick Roberts writes: > > The previous code suggestion I gave was not well thought out. The > > correct way to implement this is as follows. I've checked that with > > this change, the addition of wait_reading_process_output_unwind does > > not cause a crash when C-g is done during sit-for. > > > > Do you think this is the right approach? Clever! Yes. > >... > > It looks good to my inexperienced eye, but Emacs seems to go for a long time > before hitting Fsignal. I wonder if Fsignal resets other things that might not > add up in the interim period but I don't know what the rules are for placing > the QUIT macro or whether one could be placed closer to read_char. I don't follow this argument. Since the purpose of setting waiting_for_input is for emacs to produce C-g, it depends on the key binding whether Fsignal is ever called. -- Kim F. Storm http://www.cua.dk