From: storm@cua.dk (Kim F. Storm)
Cc: Chong Yidong <cyd@stupidchicken.com>,
Romain Francoise <romain@orebokech.com>,
emacs-devel@gnu.org
Subject: Re: C-g crash redux
Date: Sat, 05 Aug 2006 01:35:03 +0200 [thread overview]
Message-ID: <m3vep8nkgo.fsf@kfs-l.imdomain.dk> (raw)
In-Reply-To: <17619.50473.875843.483875@kahikatea.snap.net.nz> (Nick Roberts's message of "Sat, 5 Aug 2006 10:07:37 +1200")
Nick Roberts <nickrob@snap.net.nz> writes:
> > The previous code suggestion I gave was not well thought out. The
> > correct way to implement this is as follows. I've checked that with
> > this change, the addition of wait_reading_process_output_unwind does
> > not cause a crash when C-g is done during sit-for.
> >
> > Do you think this is the right approach?
Clever! Yes.
> >...
>
> It looks good to my inexperienced eye, but Emacs seems to go for a long time
> before hitting Fsignal. I wonder if Fsignal resets other things that might not
> add up in the interim period but I don't know what the rules are for placing
> the QUIT macro or whether one could be placed closer to read_char.
I don't follow this argument.
Since the purpose of setting waiting_for_input is for emacs to produce
C-g, it depends on the key binding whether Fsignal is ever called.
--
Kim F. Storm <storm@cua.dk> http://www.cua.dk
next prev parent reply other threads:[~2006-08-04 23:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-02 20:50 C-g crash redux Romain Francoise
2006-08-02 22:07 ` Nick Roberts
2006-08-02 23:21 ` Kim F. Storm
2006-08-03 2:40 ` Nick Roberts
2006-08-03 15:13 ` Chong Yidong
2006-08-03 22:29 ` Kim F. Storm
2006-08-04 0:32 ` Chong Yidong
2006-08-04 1:49 ` Nick Roberts
2006-08-04 11:12 ` Kim F. Storm
2006-08-04 15:26 ` Chong Yidong
2006-08-04 16:03 ` Chong Yidong
2006-08-04 20:59 ` Richard Stallman
2006-08-04 22:07 ` Nick Roberts
2006-08-04 23:35 ` Kim F. Storm [this message]
2006-08-05 5:45 ` David Kastrup
2006-08-06 18:28 ` Richard Stallman
2006-08-06 20:58 ` Nick Roberts
2006-08-04 0:59 ` Nick Roberts
2006-08-03 4:16 ` Chong Yidong
2006-08-03 5:40 ` Nick Roberts
2006-08-03 7:17 ` Romain Francoise
2006-08-03 7:35 ` Stefan Monnier
2006-08-03 19:15 ` Richard Stallman
2006-08-03 19:14 ` Richard Stallman
2006-08-03 15:50 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3vep8nkgo.fsf@kfs-l.imdomain.dk \
--to=storm@cua.dk \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=romain@orebokech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.