From: "Aneesh Kumar K. V" <aneesh.kumar@linux.vnet.ibm.com>
To: Dan Nicolaescu <dann@gnu.org>
Cc: 6709@debbugs.gnu.org
Subject: bug#6709: 24.0.50; With semantic-mode enabled mo-git-blame-current gives a post-command-hook error
Date: Tue, 27 Jul 2010 10:45:17 +0530 [thread overview]
Message-ID: <m3vd814iai.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <yxqhbjlkjjt.fsf@fencepost.gnu.org>
On Mon, 26 Jul 2010 17:41:26 -0400, Dan Nicolaescu <dann@gnu.org> wrote:
> "Aneesh Kumar K. V" <aneesh.kumar@linux.vnet.ibm.com> writes:
>
> > On Sat, 24 Jul 2010 01:23:15 -0400, Dan Nicolaescu <dann@gnu.org> wrote:
> >> aneesh.kumar@linux.vnet.ibm.com writes:
> >>
> >> > Here is how to reproduce
> >> >
> >> > mo-git-blame can be downloaded from
> >> >
> >> > git://git.bunkus.org/mo-git-blame.git
> >> >
> >> > emacs -Q
> >> > M-x load-file mo-git-blame-el
> >> > open a file in git repository
> >> > M-x mo-git-blame-current
> >> >
> >> > We will see the error
> >> >
> >> > Running 'git cat-file'... done
> >> > Running 'git blame'...
> >> > Error in post-command-hook: (wrong-type-argument arrayp nil)
> >> > Git finished.
> >> > Running 'git blame'... done
> >> >
> >> > The error actually disable scroll-all-mode. So further scrolling doesn't
> >> > cause both windows to scroll
> >>
> >> Not really related to your bug report, but from the name it looks like mo-git-blame is a package for
> >> using "git blame". Can you please tell us what it has that we are
> >> missing in C-x v g ?
> >
> > I quickly tried C-x v g. This is what i found
>
> Thanks for doing this!
>
>
> > 1) No incremental blame support. That is we have to wait for the entire
> > history to be available.
>
> Does this make a difference in real life?
Yes.
> You might want to file a bug report for this, maybe it will get
> implemented.
Will do
>
> > 2) ability to blame previous version/next version in the blame window
>
> Isn't that functionality available using the p n a j w keys? Please
> see the VC-annotate menu for the command names. These commands should
> work even in the presence of renamed and moved files.
>
> > 3) Ability to show the commit information on selecting the commit.
>
> You can get the diff (using D) and the log (using L). This might need
> another bug report, if git users think it's important it can be
> implemented in about 3-4 lines of code...
>
> > 4) No scroll-all-window support so that boththe annotation information
> > and source code will scroll together
>
> The two-column.el package should help doing that...
>
> Maybe we need to ask the author of mo-git-blame-el if he wants to
> implement these features in vc-annotate.el...
I didn't really read the help to find whether these features are
supported. Now I find that i should be able to use vc-annotate.el for
all the my usecase. But i find that with vc enabled an open on the file
takes considerably more time than with vc disabled using
(setq vc-handled-backends nil)
-aneesh
next prev parent reply other threads:[~2010-07-27 5:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-22 19:43 bug#6709: 24.0.50; With semantic-mode enabled mo-git-blame-current gives a post-command-hook error aneesh.kumar
2010-07-24 5:23 ` Dan Nicolaescu
2010-07-26 14:07 ` Aneesh Kumar K. V
2010-07-26 21:41 ` Dan Nicolaescu
2010-07-27 5:15 ` Aneesh Kumar K. V [this message]
2010-07-27 5:32 ` Dan Nicolaescu
2012-03-12 19:53 ` David Engster
2012-10-16 20:30 ` David Engster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3vd814iai.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=6709@debbugs.gnu.org \
--cc=dann@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.