From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Magne Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Nebulous streaming/point bug Date: Thu, 03 Nov 2011 21:20:32 +0100 Message-ID: References: <87sjmxt5ho.fsf@lifelogs.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1320351672 3636 80.91.229.12 (3 Nov 2011 20:21:12 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 3 Nov 2011 20:21:12 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 03 21:21:09 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RM3me-0006aQ-I2 for ged-emacs-devel@m.gmane.org; Thu, 03 Nov 2011 21:21:08 +0100 Original-Received: from localhost ([::1]:33200 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RM3md-0004qY-VZ for ged-emacs-devel@m.gmane.org; Thu, 03 Nov 2011 16:21:07 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:56937) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RM3mZ-0004lS-Lg for emacs-devel@gnu.org; Thu, 03 Nov 2011 16:21:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RM3mX-0005TD-8y for emacs-devel@gnu.org; Thu, 03 Nov 2011 16:21:03 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:54097) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RM3mX-0005SH-03 for emacs-devel@gnu.org; Thu, 03 Nov 2011 16:21:01 -0400 Original-Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1RM3mL-0003WA-Or for emacs-devel@gnu.org; Thu, 03 Nov 2011 21:20:49 +0100 In-Reply-To: <87sjmxt5ho.fsf@lifelogs.com> (Ted Zlatanov's message of "Thu, 13 Oct 2011 07:56:19 -0500") User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.90 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEW4uKB2aFsHBgPKy7X1 9ew1JyKgmoQdw2qBAAACRUlEQVQ4jW3TwW7jIBAAUFxUnz3OwrmelXt2l9TnpHZ9LkTkDGt5/v8T dsCOk66KIkvhiRlmAHEqKYRw1kQkXev9SydK4n/iHDVEnWF2FhRDJ4QO4lzpQuszbQAvhofgMc38 C2cKQkhvdfy6wWdUWv+aSGSgB9CwwANcbjCMZjiOOywJugRjHht4UP9DWEGr3z+AySt6uMHxO3Ry Tf4NQNNsfoBt9MDjlkNk6AjgOHKOQjxAGRUnCblA7tAGoLzjFLxnU0jeldzgA5HLJhEZ1KHjqAmG cfyExVuO5g/SlPMDTLT4K+eBIFPlYYVjgngQ68560zuUxd5Eyt1KVZh3xIvbYU71MkQSfxhwB5nK uphnBPEX8esOHa8oK/OE9srQ7hB7Y0p1ke/oVa0UJhgSqNJ0Cq0U6B3E6HaIhVlqxCYgMvd3UE/e MrxWDE1XZkgFfuByDT2DzUCIexPVwRiHjXe8pRLcHcBWncOWw+FrR88bcAvBvxS4jq9O9jn5MJk+ xqJaNqi4Y6lXx2F649M3VG/A52jqfEtOfNp2jirNch4TSKo1x6L8xTy1mJqEmoIUlHKY8aygGrZI DcVKGlpXnPhClfUaSVPder3C0EcArpufIPBdSTXqDJPhcAzpavLzTUvtCunTY8PzroXAvW39WmCC ElHlTh3kG2rIdUzjaTQMrUtRGtmtt50r5ywUW/RtOhNflQ8wx9xCPi0LOvJnyzEFKlvPwdK84ANc dzXQYiEi1HhVllsoaoT7M0C8govQpKtatPAPwJHet4P/wP0AAAAASUVORK5CYII= X-Now-Playing: Kissing the Pink's _Naked_: "Love Lasts Forever" X-MailScanner-ID: 1RM3mL-0003WA-Or MailScanner-NULL-Check: 1320956449.87694@w3KpB7Plox0jCCyzykc3TA X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.224.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:145850 Archived-At: Ted Zlatanov writes: > Based on your patch I think it's a GnuTLS bug. They are up to 3.x now, > which makes it harder: do we keep supporting the 2.x series or do we > start using 3.x, which will be harder to obtain because it's new, > especially for the W32 build? I'd rather not support both and just move > to 3.x, which has a fairly compatible API, and see if the bug is still > there. What do you think? I think we should support both. I really want normal Emacs 24.1 users to have encrypted network connections by default. > Obviously all this would happen after the release; for now I think it's > best to use your patch and note it's temporary. If people think the approach is halfway sane, I can clean up the patch and apply, but I'd love to have some feedback first. To recap: Some versions of libgnutls do not seem to work well with select. That is, they don't say that there's anything there even though there is. So the idle loop, which does a select on all the file descriptors don't get (all) the data from gnutls sockets. My "fix" is to loop through all the channels, see whether they are gnutls sockets, and then calling emacs_gnutls_record_check_pending on each one. Since this is done in the idle loop, it's typically done once every second or so, apparently. So the performance hit should be negligible. The loop looks like this: for (channel = 0; channel < MAXDESC; ++channel) if (! NILP (chan_process[channel])) ... do stuff But it's an ugly hack. So: Add the hack or not? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/