From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Magne Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: trunk r113947: * image.c: Fix animation cache signature memory leak. Date: Mon, 19 Aug 2013 18:19:46 +0200 Message-ID: References: <521244F0.3060508@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1376929219 14480 80.91.229.3 (19 Aug 2013 16:20:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 19 Aug 2013 16:20:19 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 19 18:20:19 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VBSBj-0004tX-Fc for ged-emacs-devel@m.gmane.org; Mon, 19 Aug 2013 18:20:15 +0200 Original-Received: from localhost ([::1]:44029 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBSBi-0005JB-Uv for ged-emacs-devel@m.gmane.org; Mon, 19 Aug 2013 12:20:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33897) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBSBZ-00056x-4D for emacs-devel@gnu.org; Mon, 19 Aug 2013 12:20:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VBSBT-0005N6-S5 for emacs-devel@gnu.org; Mon, 19 Aug 2013 12:20:05 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:34354) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBSBT-0005Mp-Lo for emacs-devel@gnu.org; Mon, 19 Aug 2013 12:19:59 -0400 Original-Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1VBSBH-0007rI-1v; Mon, 19 Aug 2013 18:19:47 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAKlBMVEWTb3YVDArj1uj5+f3z 7/rRvtFuPDf9/v7////t5vT+//6miZfAp7qIWlvb856/AAACKElEQVQ4jW3SsY6bQBAA0KnSEBc0 +YCNUUQNke9ag5RsSzRSpNDQbOeKRPhqR8JyiX2KVvmApKRLsbg5iWq3cOWOf8ks5/PZmClsNG+Y 2Vkb1n2syrv1dYD92Gzy9Wx5Az/w6aMxX4dvLNe/walr+HcLHmqD+OUGij/Fw/uiKK9nlLCsWMV8 v5IfBnDHeSwjKfmvK8hpxsYeeDChDGG4WJ/+u7ofhSDPOSzHIIrmY1CGcVyNQR5zyS6hfP5ahXPJ vEtYnV7gtDKOQMgZ88zlcVenTtUQnmesYu4xNLcLfg8lwzEI4oryBj4PIeSPiK2GaJAvQ+khpgp2 g9V/ct92UjAtrl94oNGt0Qr88/T+tOV95aUpWvh0sV9Z5D20CiA5w4zSQcArlhq0sD01KqKA8qEv H7G1gNvTsfIoCsKI+3KOaUqnal+G5NtdWMlq6lct6m8WtjP7LyyDWErGmM8YJrQ4mGQaFcU6zyNK 07WyBGlBtYcG/V0U0O8vK7oKigS91NQATct8uQvorj17FcYklG/qCTgGqTGP7fH7oBvUuj4StEjE vCetKBprWsMRDsoWIepG13ASXU8EdA49tmjqt9ABAIFq6n2XweLg2DLdOUfRHTpQ1LGeLAiozlFG iYMQi07YMgVHkYEtO1CR6DJXkBHUBC4BBai9EK7rkkHtwKGHRddRuzeuBdd9R50nC5ERiM5a5p7C drA1BLazeAWK7Ayv+R7cMXiJ/66uE2jh3QDTAAAAAElFTkSuQmCC X-Now-Playing: The Cure's _Seventeen Seconds (1)_: "In Your House" X-Hashcash: 1:23:130819:emacs-devel@gnu.org::tgVKFUE1wmxLdr4T:000000000000000000000000000000000000000000BOJJ X-Hashcash: 1:23:130819:eggert@cs.ucla.edu::A7bwMAaCNsb7M1HJ:0000000000000000000000000000000000000000000Fs3C In-Reply-To: <521244F0.3060508@cs.ucla.edu> (Paul Eggert's message of "Mon, 19 Aug 2013 09:16:48 -0700") User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) X-MailScanner-ID: 1VBSBH-0007rI-1v MailScanner-NULL-Check: 1377533987.20829@1eAbsUftREXsyquOHo8Ocg X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.224.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:162881 Archived-At: Paul Eggert writes: >> you didn't test it, >> because it segfaulted the first time it was called. > > I did test it, but evidently not with enough test cases. > Sorry about the bug. But it would crash with any (animated) image, because it never allocated a cache. If I read the code correctly. :-) > To avoid such problems in the future, should we funnel future > image.c changes through you? No no. > Here's a tiny style issue that should be fixed at some point: the > version you inserted has "strcmp(" in a couple of places where it > should be "strcmp (". No, please go ahead and fix. -- (domestic pets only, the antidote for overdose, milk.) No Gnus T-Shirt for sale: http://ingebrigtsen.no/no.php and http://lars.ingebrigtsen.no/2013/08/twenty-years-of-september.html