From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master 872014e: Prevent accidental deletion of .git Date: Sun, 08 Nov 2015 23:49:27 -0500 Message-ID: References: <20151109013124.17711.29422@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1447044600 9992 80.91.229.3 (9 Nov 2015 04:50:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 9 Nov 2015 04:50:00 +0000 (UTC) Cc: "=?utf-8?Q?Fabi=C3=A1n?= E. Gallina" , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 09 05:49:52 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZveOs-0003KA-Gz for ged-emacs-devel@m.gmane.org; Mon, 09 Nov 2015 05:49:50 +0100 Original-Received: from localhost ([::1]:50133 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZveOs-0007IZ-96 for ged-emacs-devel@m.gmane.org; Sun, 08 Nov 2015 23:49:50 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41889) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZveOc-0007IT-Cs for emacs-devel@gnu.org; Sun, 08 Nov 2015 23:49:35 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZveOZ-0004fC-4O for emacs-devel@gnu.org; Sun, 08 Nov 2015 23:49:34 -0500 Original-Received: from mail-io0-x236.google.com ([2607:f8b0:4001:c06::236]:34773) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZveOY-0004f3-Q9 for emacs-devel@gnu.org; Sun, 08 Nov 2015 23:49:31 -0500 Original-Received: by iody8 with SMTP id y8so174816096iod.1 for ; Sun, 08 Nov 2015 20:49:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim_org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=12+9j+2rRsaaWq8hhj/5+poYhSjiFelmEMBl3erVvuI=; b=JQwuvCONdnhhJC0pfZgR3aT6e8iCFdLt5UV8wg/6G/HxD0dSVwrdhxf5KvVOfIWIoz T89sgVWCHRIDFbAWjMMWIt+VTJlxK8ARhvIcb/mu5kgLZz0PSGenJXLMpVszoIEOC/rU G2agqxuscHV/3FTPSlIvBXGywHsWracZKzfWl5igJCzM35d/6ZBTDNIZKA9TyYpxCqyM P/qDnXmSJADi1hyHcErG5oZ3jrw1e2aB8mAVh4dRbUBtu3wjtIn7Gp0Yzmr+Jknda7OU 9g4n7/a57SfY2AtLUz3t6gVvNUtP3qcM5tc9zmiUMrDiE4p1bkAZoqT2uL8iQz3XMkit Rafg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=12+9j+2rRsaaWq8hhj/5+poYhSjiFelmEMBl3erVvuI=; b=P/WobO2Huf4DVwMZR2UfYtLgIFua+0mopkeiygWnZjEzRDvhasur619ELkq6f6LUJo wlGmJeRymxLyaMnO3bL0QT0pUtlG92bs4CxAVVG3pMGek5uSli4rRwSmrwL8qdpxWu57 3SX7D8bT8EGDfrwT1BZF7RIsjEydKfzCaM1A4FZ3zM4HBUk/2r9OO6Y1YI5zQqEQAI4y ZNGPpeetqIolmr0x83KO8bbG8PypQEKeTNL65xoJbCHZXWeFj4H8KorTTK9R7D+WiCS4 l54oh36qRC8YhBRpbjq1t4s7Abumvd/zIYPJfzfRorC9Oc1VgNBVX+U8M9zSJD+c8xaL qIUg== X-Gm-Message-State: ALoCoQlvFvGTLyI2tPVyFLRiFBK+brWlIGcYFbU6VRwlzd6EoIG+6Rw+Ycvn2n5Qf+VsPw/qCKXZ X-Received: by 10.107.31.138 with SMTP id f132mr25181836iof.84.1447044569239; Sun, 08 Nov 2015 20:49:29 -0800 (PST) Original-Received: from hp-dv5t (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id 4sm4972082igz.2.2015.11.08.20.49.28 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 Nov 2015 20:49:28 -0800 (PST) In-Reply-To: (Stefan Monnier's message of "Sun, 08 Nov 2015 20:58:09 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4001:c06::236 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:193684 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Stefan Monnier writes: >> +# Use && after the cd commands, not ;, to ensure the build fails >> +# immediately if the directory $(ARCHIVE_TMP)/packages does not exist. >> +# For process-archive this is crucial; otherwise batch-make-archive in >> +# archive-contents.el will interpret directories in the current >> +# directory as unreleased packages, and recursively delete them, >> +# including .git. Prior to using &&, running "make process-archive" >> +# could silently delete all local git history! > > Actually, I think the problem is in the code which does the deletion: it > should only do the delete files it positively knows should be deleted, > rather than deleting any files which seem to be out of place. Agreed that the deletion code is questionable, though I guess it's operating under the assumption that it's within a throwaway directory and is erring on the side of not publishing something not intended for publication. I think using && after the cd is just good practice, and I wanted to push at least a partial fix for this right away since it bit me today. > Once we change the handling of :core in elpa/admin/archive-contents.el > so that it sets up symlinks rather than performing copies, we should at > least be able to make the deletion less dangerous, e.g. by only deleting > symlinks and empty directories (so even if the deletion was erroneous, > no actual file contents was destroyed along the way). > > Fabi=C3=A1n, any news on this? Arthur pointed out in another thread that this code is at least partially there already (I haven't heard from Fabi=C3=A1n about its status). The attached patch seems to work with a locally-generated archive, but it introduces the first external to make use of :core. Should I push it and see what happens? Thomas --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Add-ntlm-to-externals-list.patch >From 4058dd04d88120b914a65f756356ac1aad42f224 Mon Sep 17 00:00:00 2001 From: Thomas Fitzsimmons Date: Sun, 8 Nov 2015 23:33:49 -0500 Subject: [PATCH] Add ntlm to externals-list * externals-list ("ntlm"): New core entry. --- externals-list | 1 + 1 file changed, 1 insertion(+) diff --git a/externals-list b/externals-list index ea0a69c..dd9ea61 100644 --- a/externals-list +++ b/externals-list @@ -59,6 +59,7 @@ ("math-symbol-lists" :subtree "https://github.com/vspinu/math-symbol-lists.git") ("nameless" :subtree "https://github.com/Malabarba/Nameless") ("names" :subtree "http://github.com/Bruce-Connor/names") + ("ntlm" :core "lisp/net/ntlm.el") ("omn-mode" :external nil) ("pabbrev" :external "https://github.com/phillord/pabbrev.git") ("pinentry" :subtree "https://github.com/ueno/pinentry-el.git") -- 2.4.3 --=-=-=--