From: Lars Ingebrigtsen <larsi@gnus.org>
To: Juri Linkov <juri@linkov.net>
Cc: "Antoine Beaupré" <anarcat@orangeseeds.org>, 35326@debbugs.gnu.org
Subject: bug#35326: 26.1; vc-git-grep should pass -i like isearch
Date: Tue, 25 Jun 2019 12:59:44 +0200 [thread overview]
Message-ID: <m3v9wuexr3.fsf@gnus.org> (raw)
In-Reply-To: <87v9wu4sqo.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 24 Jun 2019 23:45:51 +0300")
Juri Linkov <juri@linkov.net> writes:
> The confusion was caused by the original report mentioning `M-x grep'.
> In fact, `M-x grep' doesn't expand the template. Only the following
> commands expand the template:
>
> lgrep
> rgrep
> vc-git-grep
>
>> And should the vc-git version be more like grep or lgrep?
>
> vc-git-grep should be like other commands that expand the template,
> i.e. lgrep and rgrep, that the patch in the original report
> correctly achieves, so committing it would be an improvement
> since `git grep' supports most of grep options, including --color,
> -i and -w.
Makes sense. I've now applied Antoine's patch to the trunk.
> PS: Regarding -w that I proposed previously, I could create
> a separate request, but here is a preliminary version:
[...]
> + (when grep-word-search
> + (push "-w" opts))
Hm... I always just say \bfoo\b when I want the word-ish version, so I
don't know whether this really warrants a new command.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2019-06-25 10:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-19 18:10 bug#35326: 26.1; vc-git-grep should pass -i like isearch Antoine Beaupré
2019-06-23 19:02 ` Lars Ingebrigtsen
2019-06-23 21:38 ` Juri Linkov
2019-06-23 21:46 ` Lars Ingebrigtsen
2019-06-24 20:45 ` Juri Linkov
2019-06-25 10:59 ` Lars Ingebrigtsen [this message]
2019-06-27 20:31 ` Juri Linkov
2019-06-25 11:00 ` Lars Ingebrigtsen
2019-06-25 13:03 ` Antoine Beaupré
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3v9wuexr3.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=35326@debbugs.gnu.org \
--cc=anarcat@orangeseeds.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.