including systime.h twice?

including systime.h twice?

[Pavel Janík]

Hi,

in keyboard.c, we include systime.h twice. What about this? I think that
the comment before this is useless now so we can remove it
completely. Right?

--- keyboard.c.~1.655.~	Wed Feb 13 18:08:57 2002
+++ keyboard.c	Wed Feb 13 21:55:20 2002
@@ -75,9 +75,6 @@
 #include "macterm.h"
 #endif
 
-/* Include systime.h after xterm.h to avoid double inclusion of time.h. */
-#include "systime.h"
-
 #ifndef USE_CRT_DLL
 extern int errno;
 #endif


-- 
Pavel Janík

So the solution is not build ACPI as a module, because it shouldn't have
allowed you to do so in the first place :)
                  -- Jeff Garzik in linux-kernel

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-devel

Re: including systime.h twice?

[Richard Stallman]

    in keyboard.c, we include systime.h twice. What about this? I think that
    the comment before this is useless now so we can remove it
    completely. Right?

    -/* Include systime.h after xterm.h to avoid double inclusion of time.h. */

Indeed, the second #include is a no-op, so deleting it would change
nothing.  However, the comment suggests there was once a reason
why it was wrong to do the include any earlier.

I checked xterm.h and it no longer has a way to include time.h.
So I think the comment is obsolete, there is no bug, and your change
is ok.


_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-devel