From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: joakim@verona.se Newsgroups: gmane.emacs.devel Subject: Can we apply this patch for bug 84 and 425? Date: Tue, 07 Oct 2008 19:37:34 +0200 Message-ID: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1223401252 8144 80.91.229.12 (7 Oct 2008 17:40:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 7 Oct 2008 17:40:52 +0000 (UTC) To: Emacs Development Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 07 19:41:51 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KnGXW-0003Gu-Sf for ged-emacs-devel@m.gmane.org; Tue, 07 Oct 2008 19:40:07 +0200 Original-Received: from localhost ([127.0.0.1]:49270 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KnGWT-0008PM-8I for ged-emacs-devel@m.gmane.org; Tue, 07 Oct 2008 13:39:01 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KnGWJ-0008JW-Cn for emacs-devel@gnu.org; Tue, 07 Oct 2008 13:38:51 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KnGWH-0008HS-L0 for emacs-devel@gnu.org; Tue, 07 Oct 2008 13:38:50 -0400 Original-Received: from [199.232.76.173] (port=55112 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KnGWH-0008HG-H9 for emacs-devel@gnu.org; Tue, 07 Oct 2008 13:38:49 -0400 Original-Received: from iwfs.imcode.com ([82.115.149.64]:53152 helo=gate.verona.se) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KnGWH-00051f-0w for emacs-devel@gnu.org; Tue, 07 Oct 2008 13:38:49 -0400 Original-Received: from localhost.localdomain (IDENT:1005@localhost [127.0.0.1]) by gate.verona.se (8.13.4/8.11.4) with ESMTP id m97Hcdmo018188 for ; Tue, 7 Oct 2008 19:38:39 +0200 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:104394 Archived-At: These bugs are both about hangs when emacs deals with external processes: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=84 http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=425 Markus Triska has a patch which reduces my experiences of the hang from about once a day to not at all so far. How can we proceed with this patch? diff --git a/src/process.c b/src/process.c index e8d0090..0cf04bc 100644 --- a/src/process.c +++ b/src/process.c @@ -4791,6 +4791,10 @@ wait_reading_process_output (time_limit, microsecs, read_kbd, do_display, else if (nread == -1 && EWOULDBLOCK == errno) break; #endif +#ifdef EBADF + else if (nread == -1 && EBADF == errno) + break; +#endif } if (total_nread > 0 && do_display) redisplay_preserve_echo_area (10); -- Joakim Verona