From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: joakim@verona.se Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets Date: Thu, 05 Feb 2015 16:54:55 +0100 Message-ID: References: <20150201003025.18138.95966@vcs.savannah.gnu.org> <54CDC38C.9080701@yandex.ru> <54CE05A0.2090701@cs.ucla.edu> <54D15CF5.3020809@cs.ucla.edu> <54D2BB6E.1040704@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1423151743 26610 80.91.229.3 (5 Feb 2015 15:55:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 5 Feb 2015 15:55:43 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 05 16:55:43 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YJOmK-0005S4-KN for ged-emacs-devel@m.gmane.org; Thu, 05 Feb 2015 16:55:40 +0100 Original-Received: from localhost ([::1]:42802 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJOmK-0006V7-3V for ged-emacs-devel@m.gmane.org; Thu, 05 Feb 2015 10:55:40 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50644) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJOmD-0006Ur-PH for emacs-devel@gnu.org; Thu, 05 Feb 2015 10:55:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJOm7-00072G-Sj for emacs-devel@gnu.org; Thu, 05 Feb 2015 10:55:33 -0500 Original-Received: from mx2.bahnhof.se ([213.80.101.12]:39821) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJOm7-000720-MF for emacs-devel@gnu.org; Thu, 05 Feb 2015 10:55:27 -0500 Original-Received: from localhost (mf.bahnhof.se [213.80.101.20]) by mx2-reinject (Postfix) with ESMTP id ADFFC40834; Thu, 5 Feb 2015 16:55:23 +0100 (CET) X-Virus-Scanned: by amavisd-new using ClamAV at bahnhof.se (MF2) Original-Received: from mf2.bahnhof.se ([127.0.0.1]) by localhost (mf2.bahnhof.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xciXNvozl8Bb; Thu, 5 Feb 2015 16:55:15 +0100 (CET) Original-Received: from mta.verona.se (h-235-62.a149.priv.bahnhof.se [85.24.235.62]) by mf2.bahnhof.se (Postfix) with ESMTP id 40987940238; Thu, 5 Feb 2015 16:55:15 +0100 (CET) Original-Received: from localhost (unknown [127.0.0.1]) by mta.verona.se (Postfix) with ESMTP id 0699A52B91F; Thu, 5 Feb 2015 15:55:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at verona.se Original-Received: from mta.verona.se ([127.0.0.1]) by localhost (exodia.verona.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Pk-rwNSBdvAY; Thu, 5 Feb 2015 16:54:55 +0100 (CET) Original-Received: from exodia.verona.se (www.verona.se [192.168.200.15]) by mta.verona.se (Postfix) with ESMTP id D47A352B926; Thu, 5 Feb 2015 16:54:55 +0100 (CET) In-Reply-To: <54D2BB6E.1040704@cs.ucla.edu> (Paul Eggert's message of "Wed, 04 Feb 2015 16:38:06 -0800") User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 213.80.101.12 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:182454 Archived-At: Paul Eggert writes: > joakim@verona.se wrote: >> I'm guessing gnu indent breaks some Emacs build macrology. > > Yes, GNU indent doesn't understand DEFUN or DEFVAR_LISP. Those, you > need to reindent by hand. Please see the patch in my earlier message > for a good style for doing that, at: > > http://lists.gnu.org/archive/html/emacs-devel/2015-02/msg00012.html > > That patch also contains several other ideas worth considering. If > you don't understand any part of that patch please ask. > Is it possible to somehow regenerate your patch against whats in the xwidget branch now? I fixed a number of things, including using gnu indent, and the src has now diverged from the state of your patch. If its not possible to regenerate the patch I will work through it by hand. Some questions on the patch though: - Are you supposed to have a space after # on ifdefed macros? - you mentioned some names are long, I suppose like webkit_osr_mime_type_policy_typedecision_requested_callback These are generated algorithmically from signal names. Do you have an idea for another algorithm? -- Joakim Verona