all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: storm@cua.dk (Kim F. Storm)
Cc: emacs-devel@gnu.org
Subject: Re: Problem report #33
Date: Sun, 14 May 2006 13:03:29 +0200	[thread overview]
Message-ID: <m3slnc3m2m.fsf@kfs-l.imdomain.dk> (raw)
In-Reply-To: <200605140438.k4E4c6Mu002995@scanner2.ics.uci.edu> (Dan Nicolaescu's message of "Sat, 13 May 2006 21:38:05 -0700")

Dan Nicolaescu <dann@ics.uci.edu> writes:

> This one reappeared after the last xterm.c checkin.
> Is it OK not to check f for NULL here?
>
> CID: 33
> Checker: NULL_RETURNS (help)
> File: base/src/emacs/src/xterm.c
> Function: handle_one_xevent
> Description: Dereferencing NULL value "f"
>
> 5801 	#ifdef HACK_EDITRES
> 5802 	        if (event.xclient.message_type
> 5803 		    == dpyinfo->Xatom_editres)
> 5804 	          {
>
> Event returned_null: Function "x_any_window_to_frame" returned NULL value (checked 8 out of 9 times) [model]
> Event var_assigned: Variable "f" assigned to NULL return value from "x_any_window_to_frame"
> Also see events: [var_assigned][dereference]
>
> 5805 		    f = x_any_window_to_frame (dpyinfo, event.xclient.window);
>
> Event dereference: Dereferencing NULL value "f"
> Also see events: [returned_null][var_assigned]
>
> 5806 	            _XEditResCheckMessages (f->output_data.x->widget, NULL,
> 5807 	                                    &event, NULL);
> 5808 		    goto done;
> 5809 	          }

Looks like a real bug -- and there's another incident a few lines below.
Here is a "fix":

*** xterm.c	14 May 2006 02:24:31 +0200	1.911
--- xterm.c	14 May 2006 13:02:15 +0200	
***************
*** 5803,5808 ****
--- 5803,5810 ----
  	    == dpyinfo->Xatom_editres)
            {
  	    f = x_any_window_to_frame (dpyinfo, event.xclient.window);
+ 	    if (!f)
+ 	      goto OTHER;
              _XEditResCheckMessages (f->output_data.x->widget, NULL,
                                      &event, NULL);
  	    goto done;
***************
*** 5820,5825 ****
--- 5822,5829 ----
                 images, only, which should have 1 page.  */
              Pixmap pixmap = (Pixmap) event.xclient.data.l[1];
  	    f = x_window_to_frame (dpyinfo, event.xclient.window);
+ 	    if (!f)
+ 	      goto OTHER;
              x_kill_gs_process (pixmap, f);
              expose_frame (f, 0, 0, 0, 0);
  	    goto done;


-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

  reply	other threads:[~2006-05-14 11:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-14  4:38 Problem report #33 Dan Nicolaescu
2006-05-14 11:03 ` Kim F. Storm [this message]
2006-05-14 11:31 ` Problem report #33 RESOLVED Jan D.
2006-05-15 21:46   ` Kim F. Storm
2006-05-16  6:16     ` Jan Djärv
2006-05-16 11:08       ` Kim F. Storm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3slnc3m2m.fsf@kfs-l.imdomain.dk \
    --to=storm@cua.dk \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.