From: storm@cua.dk (Kim F. Storm)
Cc: emacs-devel@gnu.org
Subject: Re: Bug in `next-line' when last char in line has after-string property
Date: Sun, 07 Jan 2007 23:55:19 +0100 [thread overview]
Message-ID: <m3slemo3ag.fsf@kfs-l.imdomain.dk> (raw)
In-Reply-To: <enr4s4$4qp$1@sea.gmane.org> (Ralf Angeli's message of "Sun\, 07 Jan 2007 16\:50\:27 +0100")
Ralf Angeli <angeli@caeruleus.net> writes:
> * Kim F. Storm (2007-01-05) writes:
>
>> Everybody, please watch out for problems with line movement in buffers
>> with overlay and text-property strings.
>
> If you execute the following code which inserts a few strings into the
> buffer *foo* and then puts three overlays in the buffer where each one
> is covering a line break in the buffer and using a line break in the
> display string, the line in the middle will be left out if one tries
> to move point up using `C-p' several times. Downwards with `C-n' is
> okay.
>
> This is not a regression, but also happened like this before your last
> change. It just caught my eye when checking for problems with the new
> code.
>
> (progn
> (pop-to-buffer (get-buffer-create "*foo*"))
> (dotimes (i 5)
> (insert (make-string 10 ?x) "\n"))
> (let ((ov (make-overlay 17 24)))
> (overlay-put ov 'display "aaa\n"))
> (let ((ov (make-overlay 29 35)))
> (overlay-put ov 'display "aaa\n"))
> (let ((ov (make-overlay 40 46)))
> (overlay-put ov 'display "aaa\n")))
Indeed. It is pretty easy to construct expamples like that which
break the current code. It needs a big overhaul after the release.
But thanks for testing -- and testing that the latest change
didn't make things worse :-)
--
Kim F. Storm <storm@cua.dk> http://www.cua.dk
prev parent reply other threads:[~2007-01-07 22:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-02 17:54 Bug in `next-line' when last char in line has after-string property Ben North
2007-01-04 13:07 ` Kim F. Storm
2007-01-05 0:31 ` Richard Stallman
2007-01-05 15:06 ` Kim F. Storm
2007-01-07 15:50 ` Ralf Angeli
2007-01-07 22:55 ` Kim F. Storm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3slemo3ag.fsf@kfs-l.imdomain.dk \
--to=storm@cua.dk \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.