all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Liu <sdl.web@gmail.com>
To: Drew Adams <drew.adams@oracle.com>
Cc: 16617@debbugs.gnu.org
Subject: bug#16617: 24.3.50; REGRESSION: `C-q ?' pops up annoying *Char Help* buffer
Date: Thu, 03 Apr 2014 21:34:07 +0800	[thread overview]
Message-ID: <m3sipuv8og.fsf@gmail.com> (raw)
In-Reply-To: <7367bf77-7602-4a02-82ce-804c2f88bf25@default> (Drew Adams's message of "Wed, 2 Apr 2014 10:11:38 -0700 (PDT)")

On 2014-04-03 01:11 +0800, Drew Adams wrote:
> There has been no response to this regression report, which includes a clear recipe to repro it.
>
> This problem is still present as of this build:
>

Thanks for the report and sorry I missed it.

Stefan,

Can I fix it in emacs-24 along these lines? Thanks.   - Leo

=== modified file 'lisp/simple.el'
--- lisp/simple.el	2014-04-02 15:14:50 +0000
+++ lisp/simple.el	2014-04-03 13:31:12 +0000
@@ -658,11 +658,17 @@
 The optional argument PROMPT specifies a string to use to prompt the user.
 The variable `read-quoted-char-radix' controls which radix to use
 for numeric input."
-  (let ((message-log-max nil) done (first t) (code 0) translated)
+  (let ((message-log-max nil)
+	(help-events (delq nil (mapcar (lambda (c) (unless (characterp c) c))
+				       help-event-list)))
+	done (first t) (code 0) translated)
     (while (not done)
       (let ((inhibit-quit first)
-	    ;; Don't let C-h get the help message--only help function keys.
+	    ;; Don't let C-h or other help chars get the help
+	    ;; message--only help function keys. See bug#16617.
 	    (help-char nil)
+	    (help-event-list help-events)
 	    (help-form
 	     "Type the special character you want to use,
 or the octal character code.





  parent reply	other threads:[~2014-04-03 13:34 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-01 19:15 bug#16617: 24.3.50; REGRESSION: `C-q ?' pops up annoying *Char Help* buffer Drew Adams
2014-04-02 17:11 ` Drew Adams
2014-04-03 11:04   ` Dmitry Gutov
2014-04-03 14:32     ` Drew Adams
2014-04-03 15:16       ` Eli Zaretskii
2014-04-03 15:23         ` Dmitry Gutov
2014-04-03 13:34   ` Leo Liu [this message]
2014-04-03 15:14     ` Eli Zaretskii
2014-04-03 15:39       ` Leo Liu
2014-04-03 15:51         ` Eli Zaretskii
2014-06-19 15:43     ` Stefan Monnier
2014-06-20  0:16       ` Leo Liu
2014-04-03 16:24 ` Eli Zaretskii
2014-04-06 19:33   ` Stefan Monnier
2014-04-07  2:43     ` Eli Zaretskii
     [not found] <<891cf052-6085-4ad4-b03b-83379a85ff0f@default>
     [not found] ` <<7367bf77-7602-4a02-82ce-804c2f88bf25@default>
     [not found]   ` <<m3sipuv8og.fsf@gmail.com>
     [not found]     ` <<831txebg2x.fsf@gnu.org>
2014-04-03 18:38       ` Drew Adams
2014-04-03 19:24         ` Eli Zaretskii
2014-04-03 19:32           ` Daniel Colascione
2014-04-04  7:44             ` Eli Zaretskii
     [not found] <<f87a9a1b-9378-4755-bbac-c88209ed8297@default>
     [not found] ` <<83ppky9pyn.fsf@gnu.org>
2014-04-03 20:58   ` Drew Adams
2014-04-04  8:02     ` Eli Zaretskii
     [not found]   ` <<533DB732.70704@dancol.org>
     [not found]     ` <<83k3b5a69r.fsf@gnu.org>
2014-04-04 16:25       ` Drew Adams
2014-04-04 19:43         ` Eli Zaretskii
     [not found] <<f842dbc1-09a3-4601-9f98-e580906762c7@default>
     [not found] ` <<83r45c98yb.fsf@gnu.org>
2014-04-04 20:20   ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3sipuv8og.fsf@gmail.com \
    --to=sdl.web@gmail.com \
    --cc=16617@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.