From: Leo Liu <sdl.web@gmail.com>
To: 17630@debbugs.gnu.org
Subject: bug#17630: 24.3.91; gv expander for a few places are incorrect
Date: Thu, 29 May 2014 19:36:22 +0800 [thread overview]
Message-ID: <m3sinses09.fsf@gmail.com> (raw)
Hi Stefan,
These are incorrect:
(gv-define-simple-setter window-buffer set-window-buffer)
(gv-define-simple-setter window-display-table set-window-display-table 'fix)
(gv-define-simple-setter window-dedicated-p set-window-dedicated-p)
(gv-define-simple-setter window-hscroll set-window-hscroll)
(gv-define-simple-setter window-point set-window-point)
(gv-define-simple-setter window-start set-window-start)
The getter allows optional WINDOW arg but the setter requires WINDOW
arg. For example:
(setf (window-buffer) (get-buffer "abc")) expands incorrectly to
(set-window-buffer (get-buffer "abc"))
They should probably all be re-defined using gv-define-setter.
Leo
next reply other threads:[~2014-05-29 11:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 11:36 Leo Liu [this message]
2014-05-29 13:18 ` bug#17630: 24.3.91; gv expander for a few places are incorrect Stefan Monnier
2014-05-30 3:46 ` Leo Liu
2014-05-30 16:20 ` Stefan Monnier
2014-05-31 3:04 ` Leo Liu
2014-05-31 14:32 ` Stefan Monnier
2014-05-31 14:37 ` Stefan Monnier
2014-05-31 15:47 ` Leo Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3sinses09.fsf@gmail.com \
--to=sdl.web@gmail.com \
--cc=17630@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.