From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Magne Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Displaying images with recent trunk Date: Tue, 12 Aug 2014 16:02:53 +0200 Message-ID: References: <53EA189E.5010408@alice.it> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1407852216 19719 80.91.229.3 (12 Aug 2014 14:03:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 12 Aug 2014 14:03:36 +0000 (UTC) Cc: Emacs developers To: Angelo Graziosi Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 12 16:03:31 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XHCfh-0005Z1-6x for ged-emacs-devel@m.gmane.org; Tue, 12 Aug 2014 16:03:29 +0200 Original-Received: from localhost ([::1]:42317 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XHCfg-0005gl-MC for ged-emacs-devel@m.gmane.org; Tue, 12 Aug 2014 10:03:28 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47268) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XHCfW-0005Tu-4Q for emacs-devel@gnu.org; Tue, 12 Aug 2014 10:03:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XHCfP-0000HC-Si for emacs-devel@gnu.org; Tue, 12 Aug 2014 10:03:18 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:49081) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XHCfP-0000H5-K9 for emacs-devel@gnu.org; Tue, 12 Aug 2014 10:03:11 -0400 Original-Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1XHCf7-0003DD-Jk; Tue, 12 Aug 2014 16:02:53 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAGFBMVEUFAwRtdJRTVmkMCw8l IykvLzZARFq/xuCLintIAAACTUlEQVQ4jX3UMXebMBAHcKWG7Mdr0SzV4JVY4NnBQnMQSJ2RbXnG Q/X1e0DixGkb/Fj4vbs/0iGTOGI2ijxRZE9IhDdhzcujJqT6CrbGE/sfWFnRCVEe7iGOc6HlDEKI u4xcOJ5JWXUTmBnwrVQU5yWE8EOqXkrJ7HH3DlUI4Xq2Z2N6WKBaoEEYvcu99+ARVktGnDuKkLAE BfjP3Vt4zOlUAQAJ58DX2xvkv0KYiUJCIavdDeoF6AiMQqrd6hZOF7gO6QziL2ivAVL3DuUCuMwU YXDFDdgM45jIAMnA3yqykrGRhhGX39MPEGXCmZyF6wZ3bFroR5AnHZIJaIA76M+G5giYfw8O96PF bvQTDA7o78tIsYACS8TrBPGtEMZNOF0g0PEzhIHiBkN4hQFbmQX0GBIPbxkPCNXSygPkfoOwnuDJ Pia2YQmE335Ibf4BvsEFRtwPHMfYBhqS4bRAnGErDknucu74BeE4Z3BrLXaH6aPC6wIzlNGDU1pb YDA99b1kOKhurnCqtgip5Jwx3rY42hmenbbWgPuuAOgG2DObQUbtoDCEu5NMpQTZ1zqrEcq4dfi8 5z5lwPBT7Gq93i7ArbKGm3OT88YcRa1PM2xbV1uFkBlvD7tDUevjbl+QUrUOM6YK/O2bA6ltt8Oz WNmWK2WbqeIsC9UhvDy+ELKzz7hybNWce1OKd1B167RSDW9OfR+JUsyArax9zZDrpouKVUFqNUNT PemqqoTHc15EBZ7zCbCVjB5w5hEx8z/DAvupYoHyn6C+rDh/gj+/x+9XNVu7pQAAAABJRU5ErkJg gg== X-Now-Playing: Gus Gus's _This Is Normal_: "Bambi" X-Hashcash: 1:23:140812:emacs-devel@gnu.org::jy5FTA7m/btkzFrv:0000000000000000000000000000000000000000001IFC X-Hashcash: 1:23:140812:angelo.graziosi@alice.it::0fWttxWU6k0N2b9S:0000000000000000000000000000000000000GyHL In-Reply-To: <53EA189E.5010408@alice.it> (Angelo Graziosi's message of "Tue, 12 Aug 2014 15:37:34 +0200") User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/24.4.50 (gnu/linux) X-MailScanner-ID: 1XHCf7-0003DD-Jk MailScanner-NULL-Check: 1408456973.79185@caCNWYCaGfrfMyChMlzGrA X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.224.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:173598 Archived-At: Angelo Graziosi writes: > I wonder if someone has tried to display imaged with trunk, say, after > Aug 05, 2014. Hey, that's when I tinkered with image-mode... > For example try this: > > 1. emacs -Q > > 2. C-x C-f > /usr/local/Emacs.app/share/icons/hicolor/128x128/apps/emacs.png. It > looks OK. > > 3. Now on menu bar click 'Image' and then 'Fit Frame to > image'. Question: How to revert (undo) this? > > 4. Click on menu bar 'Image' and then 'Fit to Window Height' > > 5. Click on menu bar 'Image' and then 'Fit to Window width' > > Repeat 3., 4., 5. in different order... and with various files... > > Sometimes (I have tried with several PNG and JPG files), 4. and > 5. gives the same result, i.e. a deformed image (which does not > maintain the aspect ratio). Is this by design? I'm unable to reproduce this bug. Do you have a reproducible recipe? The change I introduced was 1) to use imagemagick instead of the other drivers, and 2) set max-width/max-height to the window. I wanted to introduce reasonable defaults when viewing images, but the logic in how image-mode.el displays images is kinda hard to follow, so I may have done this in a sub-optimal manner. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no