From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: joakim@verona.se Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets Date: Mon, 09 Feb 2015 21:24:24 +0100 Message-ID: References: <20150201003025.18138.95966@vcs.savannah.gnu.org> <54CDC38C.9080701@yandex.ru> <54CE05A0.2090701@cs.ucla.edu> <54D15CF5.3020809@cs.ucla.edu> <54D2BB6E.1040704@cs.ucla.edu> <54D90EE4.1000808@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1423513516 14713 80.91.229.3 (9 Feb 2015 20:25:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 9 Feb 2015 20:25:16 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 09 21:25:16 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YKutN-0007Gv-Pu for ged-emacs-devel@m.gmane.org; Mon, 09 Feb 2015 21:25:13 +0100 Original-Received: from localhost ([::1]:35067 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKutN-0008Ia-0Y for ged-emacs-devel@m.gmane.org; Mon, 09 Feb 2015 15:25:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60453) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKut9-0008Hp-21 for emacs-devel@gnu.org; Mon, 09 Feb 2015 15:25:00 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YKut5-00086w-Mp for emacs-devel@gnu.org; Mon, 09 Feb 2015 15:24:59 -0500 Original-Received: from mx2.bahnhof.se ([213.80.101.12]:41294) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKut5-000869-G3 for emacs-devel@gnu.org; Mon, 09 Feb 2015 15:24:55 -0500 Original-Received: from localhost (mf.bahnhof.se [213.80.101.20]) by mx2-reinject (Postfix) with ESMTP id 13D6D40B36; Mon, 9 Feb 2015 21:24:54 +0100 (CET) X-Virus-Scanned: by amavisd-new using ClamAV at bahnhof.se (MF1) Original-Received: from mf1.bahnhof.se ([127.0.0.1]) by localhost (mf1.bahnhof.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DrW8EuD0TluF; Mon, 9 Feb 2015 21:24:49 +0100 (CET) Original-Received: from mta.verona.se (h-235-62.a149.priv.bahnhof.se [85.24.235.62]) by mf1.bahnhof.se (Postfix) with ESMTP id 6A787330AF5; Mon, 9 Feb 2015 21:24:48 +0100 (CET) Original-Received: from localhost (unknown [127.0.0.1]) by mta.verona.se (Postfix) with ESMTP id D0F2452BDD9; Mon, 9 Feb 2015 20:24:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at verona.se Original-Received: from mta.verona.se ([127.0.0.1]) by localhost (exodia.verona.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Bbo6T2Z6hkRT; Mon, 9 Feb 2015 21:24:30 +0100 (CET) Original-Received: from exodia.verona.se (www.verona.se [192.168.200.15]) by mta.verona.se (Postfix) with ESMTP id 3283552BDD6; Mon, 9 Feb 2015 21:24:24 +0100 (CET) In-Reply-To: <54D90EE4.1000808@cs.ucla.edu> (Paul Eggert's message of "Mon, 09 Feb 2015 11:47:48 -0800") User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 213.80.101.12 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:182741 Archived-At: Paul Eggert writes: > On 02/09/2015 03:56 AM, joakim@verona.se wrote: >> --- a/src/coding.c >> +++ b/src/coding.c >> @@ -5985,7 +5985,7 @@ bool >> raw_text_coding_system_p (struct coding_system *coding) >> { >> return (coding->decoder == decode_coding_raw_text >> - && coding->encoder == encode_coding_raw_text) ? true : false; >> + && coding->encoder == encode_coding_raw_text); >> } >> > > Generally speaking, if EXPR is a boolean expression, it's simpler and > clearer to write 'EXPR' than to write 'EXPR ? true : false'. Also, it > makes for clearer indenting in this case. My concern was that I have made no changees AFAIK to coding.c. So how did it wind up in the patch you provided? >> And these: >> - next_element_from_stretch >> + next_element_from_stretch, >> #ifdef HAVE_XWIDGETS >> - ,next_element_from_xwidget >> + next_element_from_xwidget, >> >> is it really correct to move the coma out of the ifdef? > > Yes, in C99, which Emacs is now assuming. It feels weird, but well okay then. And its really considered better form? > -- Joakim Verona