From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: kmacro.el Date: Tue, 30 Nov 2004 10:36:51 +0100 Message-ID: References: <200411300400.iAU40Vn26724@raven.dms.auburn.edu> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1101807943 32630 80.91.229.6 (30 Nov 2004 09:45:43 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 30 Nov 2004 09:45:43 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 30 10:45:34 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CZ4Zh-0004jh-00 for ; Tue, 30 Nov 2004 10:45:33 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CZ4j7-0003fn-SS for ged-emacs-devel@m.gmane.org; Tue, 30 Nov 2004 04:55:18 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CZ4ai-0001Ov-1c for emacs-devel@gnu.org; Tue, 30 Nov 2004 04:46:36 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CZ4ae-0001Ne-9J for emacs-devel@gnu.org; Tue, 30 Nov 2004 04:46:33 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CZ4ab-0001Mb-Of for emacs-devel@gnu.org; Tue, 30 Nov 2004 04:46:30 -0500 Original-Received: from [212.88.64.25] (helo=mail-relay.sonofon.dk) by monty-python.gnu.org with smtp (Exim 4.34) id 1CZ4Qt-0006pM-Kc for emacs-devel@gnu.org; Tue, 30 Nov 2004 04:36:28 -0500 Original-Received: (qmail 22473 invoked from network); 30 Nov 2004 09:36:24 -0000 Original-Received: from unknown (HELO kfs-l.imdomain.dk.cua.dk) (213.83.150.2) by 0 with SMTP; 30 Nov 2004 09:36:24 -0000 Original-To: Luc Teirlinck In-Reply-To: <200411300400.iAU40Vn26724@raven.dms.auburn.edu> (Luc Teirlinck's message of "Mon, 29 Nov 2004 22:00:31 -0600 (CST)") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/21.3.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:30522 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:30522 Luc Teirlinck writes: > I have the impression that the above described behavior was actually > always the _intended_ behavior and that the fact that the actual > behavior is different is an inadvertent bug, rather than intentional. Indeed -- thanks for working on this. > > The patch also removes the "(printf format)" from the `C-x C-k C-f' > prompt. This is misleading. No C style printf format is used but an > Elisp `format' format. Better no hint than a false hint. This is > a specialized function intended for more knowledgeable users anyway. > > The other two small changes seem obvious: > > (and nil ... > > makes no sense. The other `and' arguments are ignored. I don't recall why I made that change -- maybe to debug something. > > In the call to `message' the extra "%s" is necessary, because the user > could have used %s or %o sequences in the macro text, that are > intended literally. Can't we just eliminate the call to format, i.e. instead of (message "%s" (format "%s%s..." ...)) use (message "%s%s..." ...) > Once it would be determined that these changes, as well as the changes > I am going to propose to man/kmacro.texi are OK, They look OK. Please install. > I also intend to > propose several changes to docstrings that are not very clear, or even > misleading. Please do. -- Kim F. Storm http://www.cua.dk