From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: delete-process bug Date: Tue, 30 May 2006 14:11:23 +0200 Message-ID: References: <87k69eyddj.fsf@lrde.org> <87fyj0r41g.fsf@lrde.org> <20060524112846.GA12046@agmartin.aq.upm.es> <87bqtmjrsh.fsf_-_@lrde.org> <87odxjakox.fsf@lrde.org> <8764jrlewm.fsf@lrde.org> <87pshyqgtd.fsf@lrde.org> <87fyiuq9t5.fsf@lrde.org> <877j45rj3w.fsf@lrde.org> <87k684y4uz.fsf@lrde.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1148991269 1626 80.91.229.2 (30 May 2006 12:14:29 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 30 May 2006 12:14:29 +0000 (UTC) Cc: agustin.martin@hispalinux.es, Eli Zaretskii , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 30 14:14:15 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Fl36p-00046G-2S for ged-emacs-devel@m.gmane.org; Tue, 30 May 2006 14:14:03 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Fl36o-0001pg-At for ged-emacs-devel@m.gmane.org; Tue, 30 May 2006 08:14:02 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Fl36b-0001pb-Kw for emacs-devel@gnu.org; Tue, 30 May 2006 08:13:49 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Fl36Y-0001pP-7Q for emacs-devel@gnu.org; Tue, 30 May 2006 08:13:48 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Fl36Y-0001pM-1N for emacs-devel@gnu.org; Tue, 30 May 2006 08:13:46 -0400 Original-Received: from [195.41.46.236] (helo=pfepb.post.tele.dk) by monty-python.gnu.org with esmtp (Exim 4.52) id 1Fl3CH-00014h-Ve; Tue, 30 May 2006 08:19:42 -0400 Original-Received: from kfs-l.imdomain.dk.cua.dk (unknown [80.165.4.124]) by pfepb.post.tele.dk (Postfix) with SMTP id 1CF89A50052; Tue, 30 May 2006 14:13:38 +0200 (CEST) Original-To: michael.cadilhac@lrde.org (=?utf-8?Q?Micha=C3=ABl?= Cadilhac) In-Reply-To: <87k684y4uz.fsf@lrde.org> (=?utf-8?Q?Micha=C3=ABl?= Cadilhac's message of "Mon, 29 May 2006 22:04:52 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:55477 michael.cadilhac@lrde.org (Micha=C3=ABl Cadilhac) writes: > It seems that the guard we put (#ifdef SIGCHLD) was not the right > thing to do, isn't it ? I promised Eli to shut up, but it once again occurred to me that the sigchld_handler is only called _IF_ SIGCHLD is defined. That's true even on MS-Windows (which does define SIGCHLD), although it uses an indirect method to call the signal handler (see w32proc.c). Since the sigchld_handler is only installed if SIGCHLD is defined, it will only ever be called (to cleanup deleted_pid_list) if SIGCHLD is defined. So it still seems wrong to put anything on deleted_pid_list unless SIGCHLD is defined ... And sigchld_handler should be conditioned by #ifdef SIGCHLD. Sorry that I'm going round in circles (perhaps my brain in an infinite loop= :-) --=20 Kim F. Storm http://www.cua.dk