From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.devel Subject: Re: RFC: status icon support again Date: Sun, 03 Feb 2008 00:35:37 -0700 Message-ID: References: Reply-To: Tom Tromey NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1202026591 15838 80.91.229.12 (3 Feb 2008 08:16:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 3 Feb 2008 08:16:31 +0000 (UTC) Cc: emacs-devel@gnu.org To: YAMAMOTO Mitsuharu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 03 09:16:53 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JLa1z-0006va-Ln for ged-emacs-devel@m.gmane.org; Sun, 03 Feb 2008 09:16:51 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JLa1X-0000FZ-PM for ged-emacs-devel@m.gmane.org; Sun, 03 Feb 2008 03:16:23 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JLa1T-0000DG-JU for emacs-devel@gnu.org; Sun, 03 Feb 2008 03:16:19 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JLa1T-0000Co-2O for emacs-devel@gnu.org; Sun, 03 Feb 2008 03:16:19 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JLa1S-0000Cd-Vr for emacs-devel@gnu.org; Sun, 03 Feb 2008 03:16:19 -0500 Original-Received: from mx20.gnu.org ([199.232.41.8]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JLa1S-0001Ja-Bw for emacs-devel@gnu.org; Sun, 03 Feb 2008 03:16:18 -0500 Original-Received: from mx1.redhat.com ([66.187.233.31]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JLa1R-0007j7-TK for emacs-devel@gnu.org; Sun, 03 Feb 2008 03:16:18 -0500 Original-Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m138GA4M007439; Sun, 3 Feb 2008 03:16:10 -0500 Original-Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m138GAs0024832; Sun, 3 Feb 2008 03:16:10 -0500 Original-Received: from opsy.redhat.com (ton.yyz.redhat.com [10.15.16.15]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m138G9mR006572; Sun, 3 Feb 2008 03:16:10 -0500 Original-Received: by opsy.redhat.com (Postfix, from userid 500) id 14782378123; Sun, 3 Feb 2008 00:35:38 -0700 (MST) X-Attribution: Tom In-Reply-To: (YAMAMOTO Mitsuharu's message of "Sun\, 03 Feb 2008 16\:37\:56 +0900") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.990 (gnu/linux) X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 X-detected-kernel: by mx20.gnu.org: Linux 2.6 (newer, 3) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:88079 Archived-At: >>>>> ">" == YAMAMOTO Mitsuharu writes: >>>>> On Sat, 02 Feb 2008 23:35:18 -0700, Tom Tromey said: >> * I looked a little at rewriting so status icons would be part of >> keymaps, but this looked complicated and I didn't see a benefit -- >> in particular this code has no relation to toolbars at all, and I >> didn't think any code could be shared. >> Of course code cannot be shared between them without changing the >> fundamental design of your code for status icons. Do you claim that >> status icons and tool bar icons are inherently different enough to >> resort to different design in implementation code and also in elisp >> interface? I don't want to make any very strong claims. I am not really expert at Emacs internals. >> Another benefit of the use of keymaps is that it makes easier to move >> between status icons from/to tool bar icons (and possibly also between >> menu bar items?), in the case that the use of either is >> impossible/inappropriate. In my view toolbars and the status area are very different; though it is true that there is some overlap between them. Pretty much every buffer can be expected to have a toolbar. It is typical for the toolbar to change as the user uses different parts of an application. On the other hand, space for status icons is limited and generally they should be used for more "global" things. It would be disconcerting if the visible status icons changed frequently, say in response to switching buffers. In an earlier message you mentioned toolbars being integrated into redisplay. This was one disconnect for me -- I don't see how, or why, we would want to integrate status icons into redisplay. They are not connected to a frame at all. >> I think user-configurable event dispatcher >> tables should always be implemented as keymaps unless there are strong >> reasons to avoid them. May I ask why? I have basically two reasons for the approach I have taken. First, it is simple and easy to understand. In Gtk, a status icon only has two possible events; using a keymap for this seemed like overkill. Second, unlike the keymap idea, I knew how to implement it this way. I suppose ignorance is no excuse, though. Could you help with the next reimplementation? Tom