From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Magne Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#7112: 24.0.50; [PATCH] `ls-lisp-insert-directory' should be no-op for empty FILE Date: Tue, 02 Aug 2011 23:32:07 +0200 Message-ID: References: <68BA79A0F7304F01870834FE12F89A36@us.oracle.com> <4B2D12A22D88427F8DD7DFA8BBFC10DA@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1312320822 3553 80.91.229.12 (2 Aug 2011 21:33:42 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 2 Aug 2011 21:33:42 +0000 (UTC) Cc: 7112-close@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 02 23:33:37 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QoMan-00010H-7J for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Aug 2011 23:33:37 +0200 Original-Received: from localhost ([::1]:36241 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QoMam-0003RA-QN for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Aug 2011 17:33:36 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:58770) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QoMaj-0003OD-Ig for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2011 17:33:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QoMai-00065m-8a for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2011 17:33:33 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51522) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QoMai-00065g-5b for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2011 17:33:32 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QoMbB-0005el-OW for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2011 17:34:01 -0400 Resent-From: Lars Magne Ingebrigtsen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Aug 2011 21:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 7112 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 7112@debbugs.gnu.org, larsi@gnus.org Original-Received: via spool by 7112-done@debbugs.gnu.org id=D7112.131232079221685 (code D ref 7112); Tue, 02 Aug 2011 21:34:01 +0000 Original-Received: (at 7112-close) by debbugs.gnu.org; 2 Aug 2011 21:33:12 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QoMaO-0005di-Kl for submit@debbugs.gnu.org; Tue, 02 Aug 2011 17:33:12 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QoMaL-0005dZ-Pv for 7112-close@debbugs.gnu.org; Tue, 02 Aug 2011 17:33:11 -0400 Original-Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1QoMZk-0001Sq-5U; Tue, 02 Aug 2011 23:32:32 +0200 In-Reply-To: <4B2D12A22D88427F8DD7DFA8BBFC10DA@us.oracle.com> (Drew Adams's message of "Tue, 2 Aug 2011 14:25:08 -0700 (PDT)") User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAD1BMVEXk49wgFxqmnYhSPTx2 bl9MMLAFAAACSElEQVQ4jVWUYZbrIAiFObYLqEMW4BAXMAYXkAj7X9O7aNqZx48e4yeIcCkRUVUh ktoybLhl3bGgMD3x88i5WeYTu+0DjgmaWhvSsubMYwJW/OyZt8Zlz40zO4I/fh5s9UXWNpyknRvr Jgknt52tM6nohSue2E5HAXhmZdVefIhcvZDakWwIcs3Yb1oMm3tB8lsh80Qme9ZRvVu8JkxwD9YH 8uyjVm9MtyVXPugkQ0TZVfPXDXZjjVOXn0kUIJflYE2n+6VDcAZleE1QUZjWCKlod2QG9FoOhnXD HRRRVH20rwWGoor0Q8KIoj3KVyY4eoBNrtmHKqlxx/6wuI4p22zQGSBzoereFlh2mCAUYj3V0Sr+ AOYZIZ4tiKEfcBtAqtz+hFqNjk6nPef/wMoFZvG1LTBf0lZNksV3p3UWfe7XkkZyPIwNgA/Hw+2w 827UFYUjlM+H7939ePcp3D1Axy7sfIOQFQBa5CHYXj4e+UyN2A0OdSrnBhdDB9QFZXMpdXxA6CjT SNOl1Pq+43ujBSp0iNts6hJuUXxRkgRNuYjF7SWVSOoHLiQCNOChCo8U4aE2sgCwSMAAnkRo+EA3 IxTVABYlAdsvxkHGcnpoTAKdJ2aUB5QWM5ZmoABxBDKEGrTPcoJY5FyeJN+KzugEEcsdRUa4Upcs McelxENwKCIwz2GOC/FUkWe/wv1ucYzehndQkdQbzznIb9AbjVJGTGi/PtLTmCJCkg6RZW432KJz mCiMqtVRf8WIfVTckWyJWf4FTfFHIv4PAU6GAOdDya0AAAAASUVORK5CYII= X-Now-Playing: Pale Saints's _The Comforts of Madness_: "You Tear the World in Two" X-MailScanner-ID: 1QoMZk-0001Sq-5U MailScanner-NULL-Check: 1312925552.25573@qc0poc+afosnpvtgQEXpyg X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 02 Aug 2011 17:34:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:49854 Archived-At: Drew Adams writes: > `ls-lisp-insert-directory' should not raise a low-level, Args out of > range error. It should itself DTRT for an empty file name. Which is to give an error. It's a nonsensical input. >> > Why not try it yourself, using the emacs -Q recipe: >> > >> > M-: (dired '("foobar" "111.el" "")) >> >> Why would you call this function with an empty string as a parameter? > > Because you can? No experienced programmer takes refuge behind the argument > "Why would anyone ever do that?" or "Don't worry; no one would ever do that." It gives an error. If you call `dired' with `t', you get Debugger entered--Lisp error: (wrong-type-argument stringp t) file-name-as-directory(t) dired-noselect(t nil) Don't do that, then. I'm closing this report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/