From: Lars Magne Ingebrigtsen <larsi@gnus.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: 7112-close@debbugs.gnu.org
Subject: bug#7112: 24.0.50; [PATCH] `ls-lisp-insert-directory' should be no-op for empty FILE
Date: Tue, 02 Aug 2011 23:32:07 +0200 [thread overview]
Message-ID: <m3r553v6so.fsf@stories.gnus.org> (raw)
In-Reply-To: <4B2D12A22D88427F8DD7DFA8BBFC10DA@us.oracle.com> (Drew Adams's message of "Tue, 2 Aug 2011 14:25:08 -0700 (PDT)")
Drew Adams <drew.adams@oracle.com> writes:
> `ls-lisp-insert-directory' should not raise a low-level, Args out of
> range error. It should itself DTRT for an empty file name.
Which is to give an error. It's a nonsensical input.
>> > Why not try it yourself, using the emacs -Q recipe:
>> >
>> > M-: (dired '("foobar" "111.el" ""))
>>
>> Why would you call this function with an empty string as a parameter?
>
> Because you can? No experienced programmer takes refuge behind the argument
> "Why would anyone ever do that?" or "Don't worry; no one would ever do that."
It gives an error. If you call `dired' with `t', you get
Debugger entered--Lisp error: (wrong-type-argument stringp t)
file-name-as-directory(t)
dired-noselect(t nil)
Don't do that, then. I'm closing this report.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
prev parent reply other threads:[~2011-08-02 21:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-27 0:21 bug#7112: 24.0.50; [PATCH] `ls-lisp-insert-directory' should be no-op for empty FILE Drew Adams
2011-07-13 13:18 ` Lars Magne Ingebrigtsen
2011-07-13 15:13 ` Drew Adams
2011-08-02 20:06 ` Lars Magne Ingebrigtsen
2011-08-02 21:25 ` Drew Adams
2011-08-02 21:32 ` Lars Magne Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3r553v6so.fsf@stories.gnus.org \
--to=larsi@gnus.org \
--cc=7112-close@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.