From: Tom Willemse <tom@ryuslash.org>
To: 14941@debbugs.gnu.org
Subject: bug#14941: [Patch] Lighten up wrt version specification
Date: Fri, 21 Feb 2014 00:19:42 +0100 [thread overview]
Message-ID: <m3r46xmkxd.fsf@ryuslash.org> (raw)
In-Reply-To: <8b0062be-4eb9-4cfe-a994-5dbdeec4eb93@default>
[-- Attachment #1: Type: text/plain, Size: 871 bytes --]
Hey,
I said I would look at this bug and so I did. Sorry it took me so long
to undertake any action on it.
The attached merge directive/patch should take care of point #1, the
first half of #2 and point #3. Please let me know if you agree, I'll
happily fix any use cases you had in mind that still don't work.
In regard to the second half of #2, about requiring specific files,
instead of packages. How would you have package.el handle these when
downloading packages from ELPA or installing a package or file? Would
you have them skipped or would requiring a specific file prevent it from
being used in the same way? Or would the use have to make sure that file
is in their `load-path' before installing the package? What is the
use-case you have in mind?
Please let me know what you think, any comments, criticisms and
considerations would be greatly appreciated.
[-- Attachment #2: Lighten up, patch --]
[-- Type: text/plain, Size: 3722 bytes --]
# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_id: tom@ryuslash.org-20140220224957-aaup04ijncvyccgn
# target_branch: bzr://bzr.sv.gnu.org/emacs/trunk/
# testament_sha1: aec87ee7f2e339fadc41ed24fff80aebd511513f
# timestamp: 2014-02-20 23:52:58 +0100
# base_revision_id: michael.albinus@gmx.de-20140220182640-\
# jsvhe3qwzk6yylu5
#
# Begin patch
=== modified file 'lisp/ChangeLog'
--- lisp/ChangeLog 2014-02-20 14:24:13 +0000
+++ lisp/ChangeLog 2014-02-20 22:49:57 +0000
@@ -1,3 +1,11 @@
+2014-02-20 Tom Willemse <tom@ryuslash.org>
+
+ * emacs-lisp/package.el (package--prepare-dependencies): Default
+ to version "0" when no version has been specified, but a list is
+ still used.
+ (package-buffer-info): If no version header has been specified or
+ no value has been specified, default to version "0".
+
2014-02-20 Michael Albinus <michael.albinus@gmx.de>
* net/tramp.el (ls-lisp-use-insert-directory-program): Declare.
=== modified file 'lisp/emacs-lisp/package.el'
--- lisp/emacs-lisp/package.el 2014-02-12 01:20:34 +0000
+++ lisp/emacs-lisp/package.el 2014-02-20 22:49:57 +0000
@@ -1128,6 +1128,8 @@
((symbolp dep) `(,dep "0"))
((stringp dep)
(error "Invalid requirement specifier: %S" dep))
+ ((and (listp dep) (null (cdr dep)))
+ (list (car dep) "0"))
(t dep)))
deps))))
@@ -1155,11 +1157,9 @@
;; probably wants us to use it. Otherwise try Version.
(pkg-version
(or (package-strip-rcs-id (lm-header "package-version"))
- (package-strip-rcs-id (lm-header "version"))))
+ (package-strip-rcs-id (lm-header "version"))
+ "0"))
(homepage (lm-homepage)))
- (unless pkg-version
- (error
- "Package lacks a \"Version\" or \"Package-Version\" header"))
(package-desc-from-define
file-name pkg-version desc
(if requires-str
# Begin bundle
IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWW3peRYAAl7fgAA3UHf/914k
BIC////wUAV48dSlU9gBpdgoOYACYAAmAAAAAAlECGTE0Kn6p6ajyh6ag2oAGQHqBKCnqaappp7U
CND0gAANAeiNANNSg9T1AAAYENGQGQNAwEkhAE0YCA0TZBCRo00yeoMiiqFMLX6tfFGet7RS+ZeX
MsMtj500XRXtIQqJJ3iUaOFsMmpKlMwJCec6Fqk5fNukrc3zTNRVQWfulk6mUMi4md8mQaRXUzvi
pzg15gMonIGXUvKTNX7UWkBjbOfUxIH2IiSCICYIzccxDzyXEPvuhjMNSwOYwWjHyCDCHd/Ll5ZH
nRtAz4lqe7IvI+m4OB7/4Ym/cUG8dIDARmgDyVjOrbyyOKgfHsHyK9suVDXsVZN0DqFyGkxDgZzF
JwJ7QEYqHc2gsFCBANqZe73JBbWSIT0EbBqAnfYRkR37jg9uASRpsPm10utQYs1MoHHcS928LkkC
g59ryItFv8WUT6KhK8neImgQGbGhcm1ak+cwmXfCSOOewJd0mMxWQVOF9Fko7XSUQZoqmiYVLu70
KgFCAQSZNgI5QH664tAyxSlNomaob6n7vjK1yQ3Mwe5rFCgtedmmUtstHujbRJvXRGIBCAMSSm5g
ON5tMTUPhKAwWBSnLUYjuGEDPUgoIqaSFBUEjCx2EQKNpn78yEk5J/Q9gYXvF7TMdOc/GNMzGBxc
pHZfknKQhhiDykvU9xWBUOqHGGEo58IqJIOL5GAc88eMBZY8KDU1U8jTHlV+T6uLRgFgWVYF+igO
UyytMjaJLoCsweNVaRbaKwqoMRzQK7iqyMQLYRsS6HWaUOFFHUDrzdwqIDgiBdoFCT7kpIMM3Zh2
oalkTe0AiKni7lxsgbzl1zAzw4eqRgFYTVBoIs9UaB6/kxMYvnMp9lSB4u4jWrgiA2mh426GWUp5
PC7egqCvTkVhto5ko8NAJ7dnUzK4Uv79SHCuK4Cch7xAc+iPG55QKiJhF9/R4RoIo0HYv01kURGE
QQdeXEaOLxjE0DeSDLWVBaZpp/l77ArMjacysGMBhQLNWUOy7+Y8xx4KpSNnSzjImDeXCuuFYTEw
duLwzr9nSWC+DAkONvJGIPq6MfZjA5nXPebyMVRuOS8pgemGRWNlZfGgk4LImRGh39k21M3uexq5
A63YJ3eJdTwDg57FQaEbxf0ZnA5pio7rBBSxf6JEjIYf8B4AVfKIKoih+lJCcE6MJ9CNROJvmVB+
B1QWwtRLknCwAgKB+BjXUfujXOfPgG62LAStnL0dwL4h3AClY3HZMIxRHAYZIkQ5wOEcAlE49bsD
OYt3G8yUY6IwI/JLjzDe5ghANEeaxNmBllDpIsEqCSg4DjKqiuKm4VwfwDQg5Eb1BYV/eycN4Til
YJrXpcuhyBgcUBb+Lz8kgjjMJcpDWRI/ZIoX6PWHh1iyKGMgONFyPqdGaUyiGCNSigU6p8CS3EP4
UhLl4cOZD0ek0EFBPlrUiQ+XO+CZ0kBEA9RGBOKBsVYTWQtIEVMgjW5ajegoQ4oCyYRNEGwVLk3p
ZQiFLs11OhZXqGHM9sMawjvbBjxBOzezTLTHjsLi5FI6ySFEUWbBfcDqlaxxH9KwUzwqPAiMcTfq
ESeBskW9HnhxApP5+kxxKgiLA6/C6hqRUYrlzKwMFAR9E8p7cFuVH/i7kinChINvS8iw
next prev parent reply other threads:[~2014-02-20 23:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 17:32 bug#14941: 24.3.50; package.el should lighten up wrt version specification Drew Adams
2014-02-20 23:19 ` Tom Willemse [this message]
2014-03-13 13:35 ` bug#14941: [Patch] Lighten " Stefan Monnier
2014-03-13 15:42 ` Drew Adams
2014-03-13 22:12 ` Stefan Monnier
2014-03-13 23:57 ` Drew Adams
2014-03-14 13:18 ` Stefan Monnier
2014-03-16 22:15 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3r46xmkxd.fsf@ryuslash.org \
--to=tom@ryuslash.org \
--cc=14941@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.