From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Magne Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#19131: Acknowledgement (25.0.50; [PATCH] eww.el: Create simple mode to manage eww buffers) Date: Sun, 07 Dec 2014 20:36:05 +0100 Message-ID: References: <87vbm9iib9.fsf@gmail.com> <87fvddihi1.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1417981050 13031 80.91.229.3 (7 Dec 2014 19:37:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 7 Dec 2014 19:37:30 +0000 (UTC) Cc: 19131@debbugs.gnu.org To: Andrey Kotlarski Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 07 20:37:20 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Xxhdv-0006zz-C5 for geb-bug-gnu-emacs@m.gmane.org; Sun, 07 Dec 2014 20:37:19 +0100 Original-Received: from localhost ([::1]:58974 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xxhdu-0005Vc-Vo for geb-bug-gnu-emacs@m.gmane.org; Sun, 07 Dec 2014 14:37:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51346) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xxhdl-0005VI-0T for bug-gnu-emacs@gnu.org; Sun, 07 Dec 2014 14:37:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xxhde-0002dF-IA for bug-gnu-emacs@gnu.org; Sun, 07 Dec 2014 14:37:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59318) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xxhde-0002dB-EU for bug-gnu-emacs@gnu.org; Sun, 07 Dec 2014 14:37:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Xxhdd-0000q6-Oe for bug-gnu-emacs@gnu.org; Sun, 07 Dec 2014 14:37:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Magne Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Dec 2014 19:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19131 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 19131-submit@debbugs.gnu.org id=B19131.14179809863181 (code B ref 19131); Sun, 07 Dec 2014 19:37:01 +0000 Original-Received: (at 19131) by debbugs.gnu.org; 7 Dec 2014 19:36:26 +0000 Original-Received: from localhost ([127.0.0.1]:56531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xxhd3-0000pF-Kq for submit@debbugs.gnu.org; Sun, 07 Dec 2014 14:36:25 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:59048) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xxhd2-0000p7-4e for 19131@debbugs.gnu.org; Sun, 07 Dec 2014 14:36:24 -0500 Original-Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Xxhck-0007Ds-8Q; Sun, 07 Dec 2014 20:36:06 +0100 X-Now-Playing: X-TG's _Desertshore_: "The Falconer" X-Hashcash: 1:23:141207:m00naticus@gmail.com::AMxEH2GjVfMfAB22:00000000000000000000000000000000000000000HOMj X-Hashcash: 1:23:141207:19131@debbugs.gnu.org::LHlNQNOpTpGMZ25G:0000000000000000000000000000000000000002TLAz In-Reply-To: <87fvddihi1.fsf@gmail.com> (Andrey Kotlarski's message of "Fri, 21 Nov 2014 01:23:18 +0200") User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) X-MailScanner-ID: 1Xxhck-0007Ds-8Q MailScanner-NULL-Check: 1418585766.39602@XNeBhe1QC8oLqg2LWAMBlQ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:96957 Archived-At: Andrey Kotlarski writes: Looks good. Could you also document this in the eww manual? I've got some tiny nit-picks for style. > + (or buffers-info > + (error "No eww buffers")) Don't use `or' for control; use `unless'. > + (if (eobp) > + (goto-char (point-min))) And else-less if statements are usually better as `when' statements. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no