all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Magne Ingebrigtsen <larsi@gnus.org>
To: Andrey Kotlarski <m00naticus@gmail.com>
Cc: 19131@debbugs.gnu.org
Subject: bug#19131: Acknowledgement (25.0.50; [PATCH] eww.el: Create simple mode to manage eww buffers)
Date: Sun, 07 Dec 2014 20:36:05 +0100	[thread overview]
Message-ID: <m3r3wbdzh6.fsf@stories.gnus.org> (raw)
In-Reply-To: <87fvddihi1.fsf@gmail.com> (Andrey Kotlarski's message of "Fri, 21 Nov 2014 01:23:18 +0200")

Andrey Kotlarski <m00naticus@gmail.com> writes:

Looks good.  Could you also document this in the eww manual?

I've got some tiny nit-picks for style.

> +    (or buffers-info
> +        (error "No eww buffers"))

Don't use `or' for control; use `unless'.

> +  (if (eobp)
> +      (goto-char (point-min)))

And else-less if statements are usually better as `when' statements.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2014-12-07 19:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-20 23:05 bug#19131: 25.0.50; [PATCH] eww.el: Create simple mode to manage eww buffers Andrey Kotlarski
     [not found] ` <handler.19131.B.141652478814119.ack@debbugs.gnu.org>
2014-11-20 23:23   ` bug#19131: Acknowledgement (25.0.50; [PATCH] eww.el: Create simple mode to manage eww buffers) Andrey Kotlarski
2014-12-07 19:36     ` Lars Magne Ingebrigtsen [this message]
2014-12-08 13:01       ` Andrey Kotlarski
2014-12-08 18:30         ` Lars Magne Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3r3wbdzh6.fsf@stories.gnus.org \
    --to=larsi@gnus.org \
    --cc=19131@debbugs.gnu.org \
    --cc=m00naticus@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.