From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master aa5513d 1/7: excorporate-diary: Always use diary-fancy-display Date: Sat, 15 Jun 2019 09:13:47 -0400 Message-ID: References: <20190614211218.5886.59920@vcs0.savannah.gnu.org> <20190614211219.59B5721012@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="250086"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 15 15:13:57 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hc8VJ-0012vY-C5 for ged-emacs-devel@m.gmane.org; Sat, 15 Jun 2019 15:13:57 +0200 Original-Received: from localhost ([::1]:60508 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hc8VI-0007jm-EZ for ged-emacs-devel@m.gmane.org; Sat, 15 Jun 2019 09:13:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39572) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hc8VD-0007hI-0F for emacs-devel@gnu.org; Sat, 15 Jun 2019 09:13:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hc8VC-0002zD-2K for emacs-devel@gnu.org; Sat, 15 Jun 2019 09:13:50 -0400 Original-Received: from mail-io1-xd35.google.com ([2607:f8b0:4864:20::d35]:40635) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hc8VB-0002xN-N7 for emacs-devel@gnu.org; Sat, 15 Jun 2019 09:13:49 -0400 Original-Received: by mail-io1-xd35.google.com with SMTP id n5so11773257ioc.7 for ; Sat, 15 Jun 2019 06:13:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=qWq7rXLikogMUxLd2N7ANES+dReMh7XhtMWkZVzBu+0=; b=je+47hAnHtyOjJ4hcrBJg1v0Y1drWW/X/YIRdfMWxSDbZT//PKDpLAn3wnYDWzw6+k k0wA2d4TrFOaJcot7rzeFpXHPGJeRHjtu4lWFiLUzpW448JJXl49AvXiPVqMOv8nx1F9 bBp0TueYNKrYXnIHRwnymYeI2D7bwN8eOBPujRO6htrU/JxkeECTP3QaignTDVo7p1sS yrw33soIYXwN0Q43c6V818jKh4SC1zSrykh0vB1Pdlb3C1SQZMfkJrUgIzTo+VsLZ0fR o6rKJ7T8VFHhv+Sk2ODFP9mcJfS+gR3db4wZEwXApTLaTnrXEpHde1rb9OlcmbCsvO3f GStw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=qWq7rXLikogMUxLd2N7ANES+dReMh7XhtMWkZVzBu+0=; b=ARrfygb/6Ub/i9VdUAn122dnx8Y5y6J188fWUy4+TlzjMH4lI3yswDmx+ppveF3LYT l2Nis3WBB81HvDuyTKROvSuVYXTn68BRtvYZoDEnLtKLPTNrOEjpo4NYHHB839s/a6LF SyUK8T9xKcp4dAH/hoDKIn57JNKqpob70LodjVdw5XViZDDC4QT4S6kgmQTO/FF0uAZO TB4Z13cKqqLEGTtlrOcV2PtSkoJ51OuxDbbb+SEsCI1dmYrmKWoVJ23KQt9I1UqQVl7l G4WOJKqwuFDN4dVRmxnsLVy8Y5k7c+AKSOaKPSnrsjDbbwt2Xlt+KuIkqqyljPrKR9O3 t1cg== X-Gm-Message-State: APjAAAVW8mw6H8WuQ6KNgM25x1T6avDCkzhnHIc3N6l/n5Pu3tLADClb nTCgNM/XF/+GMPZRiwpf4PNtMTRyhKQ= X-Google-Smtp-Source: APXvYqwtz7VfOFPXP7PSBaKFMM53eJF6KE0Vgwhwj5tfd9yYafvPcKJXqD5Fehk65/J9JnOxBBSqgg== X-Received: by 2002:a5d:8f99:: with SMTP id l25mr44033714iol.92.1560604428469; Sat, 15 Jun 2019 06:13:48 -0700 (PDT) Original-Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id d7sm4236910iob.67.2019.06.15.06.13.47 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Sat, 15 Jun 2019 06:13:47 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Sat, 15 Jun 2019 06:32:41 -0400") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::d35 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237677 Archived-At: Hi, Stefan Monnier writes: >> + (unless (eq diary-display-function 'diary-fancy-display) >> + (warn (format >> + (concat "Excorporate diary support needs diary-fancy-display" >> + " but diary-display-function is currently %S; overriding") >> + diary-display-function)) >> + (customize-set-variable 'diary-display-function 'diary-fancy-display)) > > The warning is good, but I think that unilaterally overriding the user's > choice is a bad idea. > > For example, it prevents using a tweaked version of `diary-fancy-display`. Thanks for reviewing. Yeah, I didn't like having to do that but the stock alternative, diary-simple-display, is broken. Specifically, even with diary-include-other-diary-files in diary-list-entries-hook, diary-simple-display doesn't show included entries. Maybe that's intended behavior for diary-simple-display, but it makes it seem like Excorporate hasn't done anything (since all its entries are included entries). I'm not sure how to disallow diary-simple-display but allow tweaked versions of diary-fancy-display. (Currently I'm also relying on diary-fancy-display-mode-hook.) I suppose I could just leave the warning and remove the customize-set-variable call. I'll think about it for the next release. Maybe I should also file a bug about diary-simple-display not showing included entries. Thomas