From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Sam Steingold Newsgroups: gmane.emacs.devel Subject: Re: crash in the cvs head build of Feb 13 08:40 Date: Sun, 19 Feb 2006 17:33:23 -0500 Message-ID: References: Reply-To: sds@gnu.org NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: sea.gmane.org 1140400099 6284 80.91.229.2 (20 Feb 2006 01:48:19 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 20 Feb 2006 01:48:19 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 20 02:48:16 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FB09s-000479-P8 for ged-emacs-devel@m.gmane.org; Mon, 20 Feb 2006 02:48:13 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FB09s-0004ar-7h for ged-emacs-devel@m.gmane.org; Sun, 19 Feb 2006 20:48:12 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FAx7Y-00043m-P1 for emacs-devel@gnu.org; Sun, 19 Feb 2006 17:33:37 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FAx7V-00041Y-Sh for emacs-devel@gnu.org; Sun, 19 Feb 2006 17:33:35 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FAx7U-0003zv-Cc for emacs-devel@gnu.org; Sun, 19 Feb 2006 17:33:32 -0500 Original-Received: from [207.172.4.62] (helo=smtp02.mrf.mail.rcn.net) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FAxDH-0004p0-0H; Sun, 19 Feb 2006 17:39:31 -0500 Original-Received: from 65-78-15-12.c3-0.nwt-ubr2.sbo-nwt.ma.cable.rcn.com (HELO loiso.podval.org) ([65.78.15.12]) by smtp02.mrf.mail.rcn.net with ESMTP; 19 Feb 2006 17:33:24 -0500 X-IronPort-AV: i="4.02,128,1139202000"; d="scan'208"; a="206980388:sNHT33480408" Original-Received: by loiso.podval.org (Postfix, from userid 500) id 3238021E147; Sun, 19 Feb 2006 17:33:24 -0500 (EST) Original-To: rms@gnu.org Mail-Copies-To: never X-Attribution: Sam X-Disclaimer: You should not expect anyone to agree with me. In-Reply-To: (Richard M. Stallman's message of "Sun, 19 Feb 2006 12:45:43 -0500") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:50779 Archived-At: > * Richard M. Stallman [2006-02-19 12:45:43 -0500]: > > In this case I think it is better to be less defensive > and stick more clearly to the rules from which the code was written. > Does this patch fix the bug? I cannot reproduce the bug (with or without the patch). > *** xmenu.c 07 Feb 2006 18:13:41 -0500 1.299 > --- xmenu.c 19 Feb 2006 11:46:11 -0500 > *************** > *** 1807,1814 **** > wv->enabled = 1; > wv->button_type = BUTTON_TYPE_NONE; > wv->help = Qnil; > } > ! save_wv = wv; > prev_wv = 0; > i += MENU_ITEMS_PANE_LENGTH; > } > --- 1807,1817 ---- > wv->enabled = 1; > wv->button_type = BUTTON_TYPE_NONE; > wv->help = Qnil; > + save_wv = wv; > } > ! else > ! save_wv = first_wv; > ! > prev_wv = 0; > i += MENU_ITEMS_PANE_LENGTH; > } -- Sam Steingold (http://www.podval.org/~sds) running FC3 GNU/Linux http://truepeace.org http://www.dhimmi.com http://www.jihadwatch.org http://www.iris.org.il http://www.camera.org http://pmw.org.il http://ffii.org The software said it requires Windows 3.1 or better, so I installed Linux.