From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: Emacs allocates unnecessary memory during scrolling Date: Thu, 19 Oct 2006 11:47:00 +0200 Message-ID: References: <87r6x5432z.fsf@stupidchicken.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1161252195 9772 80.91.229.2 (19 Oct 2006 10:03:15 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 19 Oct 2006 10:03:15 +0000 (UTC) Cc: MIYOSHI Masanori , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 19 12:03:12 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GaUjN-0004w2-UT for ged-emacs-devel@m.gmane.org; Thu, 19 Oct 2006 12:02:30 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GaUjN-0005An-Gs for ged-emacs-devel@m.gmane.org; Thu, 19 Oct 2006 06:02:29 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GaUVO-0006DK-Vp for emacs-devel@gnu.org; Thu, 19 Oct 2006 05:48:03 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GaUVI-00064y-UE for emacs-devel@gnu.org; Thu, 19 Oct 2006 05:48:01 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GaUVH-00063h-WD for emacs-devel@gnu.org; Thu, 19 Oct 2006 05:47:56 -0400 Original-Received: from [195.41.46.235] (helo=pfepa.post.tele.dk) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GaUVH-0005Ng-UH for emacs-devel@gnu.org; Thu, 19 Oct 2006 05:47:56 -0400 Original-Received: from kfs-l.imdomain.dk.cua.dk (unknown [80.165.4.124]) by pfepa.post.tele.dk (Postfix) with SMTP id 303C7FAC02E; Thu, 19 Oct 2006 11:47:40 +0200 (CEST) Original-To: Chong Yidong In-Reply-To: <87r6x5432z.fsf@stupidchicken.com> (Chong Yidong's message of "Wed\, 18 Oct 2006 19\:27\:32 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:60916 Archived-At: > >>> >>> YAMAMOTO Mitsuharu san says: >>> >>> In xdisp.c: >>>> static int >>>> display_mode_line (w, face_id, format) >>> snip >>>> { >>> snip >>>> init_iterator (&it, w, -1, -1, NULL, face_id); >>>> prepare_desired_row (it.glyph_row); >>> >>> Before prepare_desired_row(), it.glyph_row->enabled_p happens not >>> to be 0. This might be caused by the interruption of redisplay >>> during scrolling. >>> >>> Appending the next code before prepare_desired_row() may fix the >>> problem. >>>> it.glyph_row->enabled_p = 0; >>> But he doesn't know the place is appropriate or not. Looking closer at the code, this is indeed a trivial way to fix the problem. I have committed the change. Thank you. -- Kim F. Storm http://www.cua.dk