From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: no-spam@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.bugs Subject: Re: accept-process-output incompatible change in CVS Emacs: patch included Date: Sat, 05 May 2007 00:33:39 +0200 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1178318041 15688 80.91.229.12 (4 May 2007 22:34:01 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 4 May 2007 22:34:01 +0000 (UTC) Cc: bug-gnu-emacs@gnu.org To: Per Cederqvist Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat May 05 00:33:58 2007 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Hk6Lc-0006iY-OZ for geb-bug-gnu-emacs@m.gmane.org; Sat, 05 May 2007 00:33:57 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hk6SI-00056I-Lx for geb-bug-gnu-emacs@m.gmane.org; Fri, 04 May 2007 18:40:50 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Hk6SH-00052W-2O for bug-gnu-emacs@gnu.org; Fri, 04 May 2007 18:40:49 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Hk6SG-0004zN-A2 for bug-gnu-emacs@gnu.org; Fri, 04 May 2007 18:40:48 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hk6SG-0004zK-6p for bug-gnu-emacs@gnu.org; Fri, 04 May 2007 18:40:48 -0400 Original-Received: from pfepa.post.tele.dk ([195.41.46.235]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Hk6LZ-0006Ro-Iy for bug-gnu-emacs@gnu.org; Fri, 04 May 2007 18:33:53 -0400 Original-Received: from kfs-l.imdomain.dk.cua.dk (0x503e2644.bynxx19.adsl-dhcp.tele.dk [80.62.38.68]) by pfepa.post.tele.dk (Postfix) with SMTP id E42A4FAC026; Sat, 5 May 2007 00:33:51 +0200 (CEST) In-Reply-To: (Per Cederqvist's message of "04 May 2007 10\:56\:47 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.98 (gnu/linux) X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:15689 Archived-At: Per Cederqvist writes: > This change in the upcoming Emacs 22 breaks some code: > >> 2006-03-22 Kim F. Storm >> >> * process.c (Faccept_process_output): Fix to comply with lisp >> reference. Change arg "timeout" to "seconds" and allow both >> integer and float value. Change arg "timeout-msec" to "millisec" >> and interpret" as milliseconds rather than microseconds. Fix doc >> string accordingly. Please see: http://lists.gnu.org/archive/html/emacs-devel/2006-03/msg00937.html > > I enclose a patch that makes accept-process-output > backwards-compatible with Emacs 21. > > One application I'm running now runs very slowly, since its carefully > tuned timeoutes are multiplied by 1000. Well, other code believing the lisp ref, and was broken by the old behaviour. So just reverting the change is no good at this time. What application is that? > If, for some reason, my patch is unacceptable, please > mention this as an incompatible change in the NEWS file. This is a good point. -- Kim F. Storm http://www.cua.dk