Re: [Emacs-diffs] /srv/bzr/emacs/trunk r112126: Reorder conditions that are written backwards

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r112126: Reorder conditions that are written backwards

[René Kyllingstad]

[-- Attachment #1: Type: text/plain, Size: 351 bytes --]

On 25 March 2013 15:06, Stefan Monnier <monnier@iro.umontreal.ca> wrote:

> >   Reorder conditions that are written backwards
>
> Backwards according to what?


If you were explaining it to someone, which would you say:

     If i is greater than zero and less than N

or

     If zero is less than i, and i is less than N


-- René

[-- Attachment #2: Type: text/html, Size: 848 bytes --]

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r112126: Reorder conditions that are written backwards

[Eli Zaretskii]

> From: René Kyllingstad <listmailemacs@kyllingstad.com>
> Date: Mon, 25 Mar 2013 16:38:06 +0100
> Cc: Andreas Schwab <schwab@linux-m68k.org>,
> 	"Emacs Dev \[emacs-devel\]" <emacs-devel@gnu.org>
> 
> > >   Reorder conditions that are written backwards
> >
> > Backwards according to what?
> 
> If you were explaining it to someone, which would you say:
> 
>      If i is greater than zero and less than N
> 
> or
> 
>      If zero is less than i, and i is less than N

This is not really relevant, as Andreas didn't change any code like
this:

  if (0 < i && i < N)

He only changed things like this:

  if (0 < i)

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r112126: Reorder conditions that are written backwards

[Paul Eggert]

On 03/25/13 08:49, Eli Zaretskii wrote:
> Andreas didn't change any code like this:
> 
>   if (0 < i && i < N)

I'm afraid that he did change some range-checking code
like that.  The actual code was more complicated (the part
before the && was a conditional), but it was definitely
using that style before he changed it.

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r112126: Reorder conditions that are written backwards

[James Cloos]

>>>>> "RK" == René Kyllingstad <listmailemacs@kyllingstad.com> writes:

RK> If you were explaining it to someone, which would you say:

RK>      If i is greater than zero and less than N

RK> or

RK>      If zero is less than i, and i is less than N

You left out:  If i is between zero and N.

The standard math notation is 0<i<N.

-JimC
-- 
James Cloos <cloos@jhcloos.com>         OpenPGP: 1024D/ED7DAEA6

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r112126: Reorder conditions that are written backwards

[Stefan Monnier]

>   Reorder conditions that are written backwards
  
Backwards according to what?


        Stefan

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r112126: Reorder conditions that are written backwards

[Andreas Schwab]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Backwards according to what?

According to common sense.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r112126: Reorder conditions that are written backwards

[Ted Zlatanov]

On Mon, 25 Mar 2013 15:32:53 +0100 Andreas Schwab <schwab@linux-m68k.org> wrote: 

AS> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> Backwards according to what?

AS> According to common sense.

My vote, FWIW, is to leave the original code alone.  Some authors prefer
to put the constant first.  Respect their style, or explicitly forbid
it, but please don't do drive-by style changes.

Ted