From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Magne Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Minor Patch: Respect browse-url-new-window-flag Date: Mon, 01 Dec 2014 05:04:31 +0100 Message-ID: References: <21627.56222.146163.316515@gargle.gargle.HOWL> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1417406717 28125 80.91.229.3 (1 Dec 2014 04:05:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 1 Dec 2014 04:05:17 +0000 (UTC) Cc: tv.raman.tv@gmail.com, emacs-devel@gnu.org To: "T. V. Raman" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 01 05:05:08 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XvIEV-0005dz-3N for ged-emacs-devel@m.gmane.org; Mon, 01 Dec 2014 05:05:07 +0100 Original-Received: from localhost ([::1]:52679 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XvIEU-0000ts-N8 for ged-emacs-devel@m.gmane.org; Sun, 30 Nov 2014 23:05:06 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57210) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XvIEM-0000sH-MB for emacs-devel@gnu.org; Sun, 30 Nov 2014 23:05:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XvIEG-0002x5-ED for emacs-devel@gnu.org; Sun, 30 Nov 2014 23:04:58 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:55846) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XvIEG-0002wz-8e for emacs-devel@gnu.org; Sun, 30 Nov 2014 23:04:52 -0500 Original-Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1XvIDw-0007Ao-2L; Mon, 01 Dec 2014 05:04:32 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEUkAgVrVjMJAAEKAQEl DQkhBgdPwAjFAAACcElEQVQ4jU1UUZbbIAzkve4Bli65AMT/DUL/xUgHyILuf5WOcLKvxLEdRmhG I0hQm6xTkhARD6Y2JvkIMaZ9xS77+huTREkjRPH5/hl7TJ9XRHzECOBDpOMnAlJPCO8p4TaCGJFt JIkZVbrnXFsBIINE+w61WTFbcq0ghwYtUxD9+F0wX/ChAmBrI/V3OvEt+QQwWphYUmtGMCLxWpDJ l4TFNHFN8vQ557Plez7vFIRX5fXH656Yz5smNw7mmajRhyylDSAbooK6dloo+dNOAIeT30mDmzjm QoGDxlaVXYShctXmpiQi97W48MmbgwiuxS9yYaWcR64DgChgB2y5IRdYQC4iaz1j+iKxbwClQMsB DhUhUCCRNa8juyeFxuXVA0BBMZPdgTIrUi0bphZn3nIg4PuAXOPQxUekwpv8ykbUXBWZJcokvzBl BHK4alcd9AWrlb3ocsAAZlgiaw4Z2wcvAuUVhnleB/m8N3vh3b6prWkraCOsBd95VJBm7xkPAGCe dHg376v6oxbvtnkqxdpc2BaIYDXrEHMOnUs8F+KyNzXTQGiwrXdXdcBo/9HWVmV4eE9ZH1DV0Hr4 /ZLbHGjpubeVr5mMVPNV2T0JitQxm4yBFepymd1sUGFSniK3K5Wujh0KUqX3mAAU9MJoBq+YErpw 62leK2zhiGA3islNrA/MXJW7MN9jwtbQz7XQYewSP2NpyWCIaLHjzPaOtGGfvsQ2pglSE+MQIbVt APsWR8RA6rsspWg/wA2RT43vYfYGYmJas+/jjzFfHD50msUXkNT+B9b+fxAH7AeAL/bcC/yoiOoP EG/y+t/YtyX/AKWs5MSLxfDgAAAAAElFTkSuQmCC X-Now-Playing: David Bowie's _Station to Station_: "TVC15" X-Hashcash: 1:23:141201:raman@google.com::vpQCsLgP0k7RFDSu:0AZ7I X-Hashcash: 1:23:141201:emacs-devel@gnu.org::YQPLArP19UuSIt38:000000000000000000000000000000000000000000MsZq X-Hashcash: 1:23:141201:tv.raman.tv@gmail.com::Pbq+g9VgXySDZogN:0000000000000000000000000000000000000000XXcW In-Reply-To: <21627.56222.146163.316515@gargle.gargle.HOWL> (T. V. Raman's message of "Sun, 30 Nov 2014 19:08:14 -0800") User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) X-MailScanner-ID: 1XvIDw-0007Ao-2L MailScanner-NULL-Check: 1418011473.43365@kqygDqpfy/p5pB4j0JYEfg X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.224.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:178564 Archived-At: "T. V. Raman" writes: > Here is a simple patch to eww.el to respect option > browse-url-new-window-flag > git diff master -- eww.el > diff --git a/lisp/net/eww.el b/lisp/net/eww.el > index 2059b5e..4613b4c 100644 > --- a/lisp/net/eww.el > +++ b/lisp/net/eww.el > @@ -680,7 +680,7 @@ the like." > > ;;;###autoload > (defun eww-browse-url (url &optional new-window) > - (cond (new-window > + (cond ((or browse-url-new-window-flagnew-window) I don't think that's appropriate. browse-url says whether to open a new window when you're opening an URL outside of a browser, not what the browser should do once you've opened it. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no