From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el Date: Fri, 02 Dec 2016 16:29:15 +0100 Message-ID: References: <6d0c8c2e-8428-2fdb-0d6e-899f7b9d7ffd@nifty.com> <0cc7fab4-9a2c-6a8d-def7-36bd50317ca3@yandex.ru> <7f9a799f-de88-fd78-0cdc-dac0928f1503@nifty.com> <308bb78f-8be3-092d-d877-e129d340242b@nifty.com> <4dc615e7-ec73-60a5-426e-0d6986f15d76@yandex.ru> <0cb406fb-ffc4-a4ad-557a-2cacc99b8e75@nifty.com> <86ccb4af-5719-c017-26bb-fc06b4c904d2@yandex.ru> <83r35uxkr5.fsf@gnu.org> <4e12d4ad-cd6b-3087-5d7c-449d4c1886e2@yandex.ru> <83lgw1q9uu.fsf@gnu.org> <83eg1tq8is.fsf@gnu.org> <787e5206-53e0-752f-a339-4608d2f7ad39@yandex.ru> <837f7lq6lg.fsf@gnu.org> <83bmwvpo0o.fsf@gnu.org> <04e2da4e-1fa3-4483-459c-32f272378486@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1480692589 20468 195.159.176.226 (2 Dec 2016 15:29:49 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 2 Dec 2016 15:29:49 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Eli Zaretskii , kentaro.nakazawa@nifty.com, p.stephani2@gmail.com, emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 02 16:29:40 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCpmM-0003vu-Jo for ged-emacs-devel@m.gmane.org; Fri, 02 Dec 2016 16:29:38 +0100 Original-Received: from localhost ([::1]:35135 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCpmQ-0006sG-Je for ged-emacs-devel@m.gmane.org; Fri, 02 Dec 2016 10:29:42 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49861) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCpmG-0006qV-Mk for emacs-devel@gnu.org; Fri, 02 Dec 2016 10:29:33 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cCpmB-0008Ke-L7 for emacs-devel@gnu.org; Fri, 02 Dec 2016 10:29:32 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:36448) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cCpmB-0008HW-E0; Fri, 02 Dec 2016 10:29:27 -0500 Original-Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=stories) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1cCplz-0003kt-C0; Fri, 02 Dec 2016 16:29:18 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAKlBMVEWCeG9+dGuhmZCZkYjP up56cGh1amNsYVmupp3UxK2Mg3rEtJ3W1M9gVU5FhO97AAACPklEQVQ4jXVTsW7UQBB9BpkilVfI +YC95iS6c4Ncu6HDQuuCLkLea4OQzhKSm6scHSWNFQorbiKnTXFo+YQUacCV/4WZ2dxxhy6vWNsz O2925z3jLmu/Z1nWErJD4M5lJ4EbrU8n+kG7U0XPU725z7L77F17gOtt0zR4S0vjXLPHxjlJ/Ho4 xjXFKdfix8Np4IpJnftJKxFonWhmdg43zVpLm+2GGBy12EorvNBaz9KB0WvestaMGW43fKQ5fc65 brP1TK1UHCAhpD0tGCvByuQKUErF1iw5IIlVXhjFiI2PVnaJzwhMLnsDpYpSxfQGIMR4QY8gpm9T Fp52GlfLCpcQFBehlWg9jdXKWoMPfIwuzHHWyY7AlqawtsRoIxjw/dAhyHFurT/Vn9II+KDvz/gG ydBB2d09qjLmwwlZTCTYJSbqegQ8Ss+AL1eU1JRY4+iMOn5J/mHwkEb4pGdPYRrhYrHbk+LrsEfP 4137fR2untP8Gy3tCUdIwsO7gsECewVn3Fm0pZD3nThxfShusxGbSuJYdinQuJXnVrISmXsKXAYR XlmjaLyRzJAfAak70vzrvVWMtRV91FWNR8ob2hgbu+IJWo+laE7DJHFCm9OMSS9L0tbeDHFEqdBb aprGmrTBx5Qd7SfaUUVMkjAXflO9iWS6ZJVAnftzeCoFOWkg+S4sI3YiV6giF3nFWhJ/MgP1kq7T 6G9D3jZ4nfyHNGCOyE93Rj7oh36h13P+uWTsLwcmZgsu/P/EXknS5C95sL2hm7FvugAAAABJRU5E rkJggg== In-Reply-To: <04e2da4e-1fa3-4483-459c-32f272378486@yandex.ru> (Dmitry Gutov's message of "Fri, 2 Dec 2016 15:18:48 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 80.91.224.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209925 Archived-At: Dmitry Gutov writes: > - (unless (= (string-bytes request) > - (length request)) > - (error "Multibyte text in HTTP request: %s" request)) > + (when (mutibyte-string-p request) > + (error "Multibyte text in HTTP request: %s, please translate This is going to break many current callers. Most people aren't doing anything as weird as trying to transmit non-ASCII text via any of these headers (it's a very uncommon thing to do), but are just passing in normal Emacs strings (containing nothing by ASCII, as is proper). These will all fail if you do this, for no real gain. Sorry to keep harping on about this, but the current url-* interface is inadequate. We should leave it be and move on to create a new, well-defined url-fetching interface. I hope to get time to do that during my next holiday, which should be in February. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no