From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: `message' not outputting the newline "atomically" Date: Tue, 25 Jun 2019 00:28:03 +0200 Message-ID: References: <07619925-e367-fb88-2dd8-27addb2e9052@grinta.net> <68b398b1-3790-b32f-535d-6ea2518f79b8@cs.ucla.edu> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="10037"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Daniele Nicolodi , emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 25 00:28:18 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfXRh-0002Q2-Aj for ged-emacs-devel@m.gmane.org; Tue, 25 Jun 2019 00:28:17 +0200 Original-Received: from localhost ([::1]:55060 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfXRg-0003Ra-Ab for ged-emacs-devel@m.gmane.org; Mon, 24 Jun 2019 18:28:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33936) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfXRZ-0003Mi-LL for emacs-devel@gnu.org; Mon, 24 Jun 2019 18:28:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfXRY-0004nx-I0 for emacs-devel@gnu.org; Mon, 24 Jun 2019 18:28:09 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:45904) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hfXRY-0004n4-9O for emacs-devel@gnu.org; Mon, 24 Jun 2019 18:28:08 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfXRT-0008Vy-VG; Tue, 25 Jun 2019 00:28:06 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAIVBMVEUmJDJybnkkHyk+OkUb FhpCPkoPBwQlICoqKDUjIzMLAwG+16mnAAACG0lEQVQ4jW2UPYsbMRCGxeHDLiPMEtIqZ9RHJ3J1 WAzposiCyx/YYiuf9pZxG2PjbQMJeP+Ai/2VmRnth+9jCoH17DszmnmxKIriUlCUHUWZfhSF+N62 bdM0Tn5q279KQ22MV0rPGGA4+YuAmtfG+ngFzg8tg1gZt9wr/TwADgRqFVz2ZVBQ/h7AU3Dy6wiW E6gRPPbg7H0PvilYBUkgEviXuRFEAtgvF/+Tyal4HcIIfkuLt1nIqMbKMpilVIY6kJKL2+C8AlYc HwgESYr42dtgYurqOHZFwCBQwABn2AMAWHljjBazlyNBUDPYHd4AiHS8BTuALYLtS3AggBVhPoAz r5FAczotGhBiUpwRYKpmHrcCcx1Edym6Ljlg8EEyA3sjkbKYTgTFu5GLCkdggw8UG62VulN4wI2o 0x2F3ygO0LDdXwNURK3u6OUEMNEIaB5owwQMXcksAQWR7kEgwFXKbASaRBEWe1FZK9N1CD+jApAf afYMUDIUxykSeJJUHK0nE6LiO7lEsDy9AqSQeDyexJF6ki4bQIUfnUTDCjQ+17fULoEPouEarMmC txvqyjj5Y4HvuGXgsIYxDNgMBKaJoEL3YJHaTe+znh5IojSSML4Pxx51D2bi9mrs9wiA1gHoXVK4 kFa4SQDwvBEVdoQAF5w2qBXuV8Nc4OLX75hh3duH/1+6brLPWpQjuGCUk33y9aQZPJYXef4fH4+u 0xlHUf8AAAAASUVORK5CYII= In-Reply-To: <68b398b1-3790-b32f-535d-6ea2518f79b8@cs.ucla.edu> (Paul Eggert's message of "Mon, 24 Jun 2019 15:03:01 -0700") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238124 Archived-At: Paul Eggert writes: > On 6/24/19 2:33 PM, Lars Ingebrigtsen wrote: >> the code also calls code_convert_string, so I thought one >> more xmalloc didn't make much difference. > > If code_convert_string could cause an infloop when reporting > low-on-memory messages, then we should fix that infloop too. In the > meantime we shouldn't make things worse by doing yet another heap > allocation. But as you've said -- this isn't a general stderr Emacs thing -- this function is called solely from `message', right? I tried tracing all the calls, and that was my conclusion, but I may well have missed something. So any very low-level messages about low-on-memory wouldn't be hitting that code at all, I would have thunk. Thinked. Thought. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no