From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] new EUDC backends for ecomplete, and mailabbrev (with ERT tests) Date: Thu, 18 Aug 2022 09:14:49 -0400 Message-ID: References: <8e9c60585677321e437a29215963a908@condition-alpha.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28770"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Cc: emacs-devel@gnu.org To: Alexander Adolf Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Aug 18 15:18:22 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oOfPh-0007LT-VY for ged-emacs-devel@m.gmane-mx.org; Thu, 18 Aug 2022 15:18:22 +0200 Original-Received: from localhost ([::1]:34892 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oOfPg-00054s-Qk for ged-emacs-devel@m.gmane-mx.org; Thu, 18 Aug 2022 09:18:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33474) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oOfMP-0002xr-7d for emacs-devel@gnu.org; Thu, 18 Aug 2022 09:14:57 -0400 Original-Received: from mail-io1-xd30.google.com ([2607:f8b0:4864:20::d30]:46020) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oOfMN-00086Y-4G for emacs-devel@gnu.org; Thu, 18 Aug 2022 09:14:56 -0400 Original-Received: by mail-io1-xd30.google.com with SMTP id z72so1025233iof.12 for ; Thu, 18 Aug 2022 06:14:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20210112.gappssmtp.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc; bh=JDJRnTqjSl/dO2IRqaC8KvYLvMZAiWY8zqnF14Iqr3E=; b=Rk54BlVyJxpAxiaNT0zhyUQCdFdRXdhL9+rHQBl2dprGWWLV778I2CMhvZXHu2ifP+ o3MmzTDLgyjrC/bbxSgnhJOIw+Rot/8RApMVD58S107KF9Kus+E9x+7VHkg0ohiFVQgD BTSvM9wojpBn6aDyaJlB1GEAkH7TI2vdD/jYlGwxnlBswcZG4GBzq14uCZWbalP8kTL1 /yitQb1q5ynIMigFWkXsgY45w1McVBZTRmaU0elh6n0Rf3HYZqDA8v6yr0+S79kqgLxn LqFy6CnOeUgDHzQTnxtUie5xC+brU8Kaqt0Nea2yvSruq1TXCGxpjkb3X/BMaajciCTW XRsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc; bh=JDJRnTqjSl/dO2IRqaC8KvYLvMZAiWY8zqnF14Iqr3E=; b=dOP+z7ACngROUD+0Dn4+hOS0Q7Wfxkkc9OX85dYgPexykZRu5eKSJ5Xx9p05FirlJ6 6odsqhuRfjLiDXr0bYAFEqPi/5fUs8afk0t40VtYQ51y//2+Nmpkd+X31d8NTE8i6VVY ebvYhzmtaU3UjK2bXIzTLBAIZ+nVV+cKzlt2LSDDC65eMt6BM1gKcDoW1onM/4sq8Grq DhseIkwq99j1IRD49HaJElLjTgvFasAFRVeQcbKj7cQ2lIfDiETbH2/hd/Q4Mqnv5Nnh q6lGQI2FScGCKZ8LMECTuz1CAKv5Gce/yKUunDslmD0S7opzP/NqcUUhhaF/CZcE393m ODfw== X-Gm-Message-State: ACgBeo0KOtWYoeWwGt1aBxs+nfIr3UvrHcVirPwLTIMSE8xDV/F6xkM5 DCFpg9JsgBOEEUMvv72NASs9TAU1oHcDlg== X-Google-Smtp-Source: AA6agR5NLgM3pGtSAJIoXmKcGX7/+RDZkc1CTCsuOvvmCtkSXiGYt7V1pBv3j3ZChsX/cZtkoUyLzg== X-Received: by 2002:a6b:e20b:0:b0:688:ce64:e580 with SMTP id z11-20020a6be20b000000b00688ce64e580mr1371361ioc.19.1660828491672; Thu, 18 Aug 2022 06:14:51 -0700 (PDT) Original-Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id f8-20020a056602088800b0068869b84b02sm839173ioz.21.2022.08.18.06.14.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Aug 2022 06:14:50 -0700 (PDT) In-Reply-To: <8e9c60585677321e437a29215963a908@condition-alpha.com> (Alexander Adolf's message of "Wed, 17 Aug 2022 02:11:21 +0200") Received-SPF: pass client-ip=2607:f8b0:4864:20::d30; envelope-from=fitzsim@fitzsim.org; helo=mail-io1-xd30.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:293605 Archived-At: Hi Alexander, These look really good, thank you. Once you've addressed Stefan's feedback in both of them, I'll push them to master for you. Thomas