From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Magne Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 11cf3e9: Implement a new function directory-files-recursively Date: Sat, 13 Dec 2014 15:42:53 +0100 Message-ID: References: <20141209062121.9440.90058@vcs.savannah.gnu.org> <87ppbrpfx4.fsf@gmail.com> <87d27o80j8.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1418481835 27977 80.91.229.3 (13 Dec 2014 14:43:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 13 Dec 2014 14:43:55 +0000 (UTC) Cc: emacs-devel@gnu.org To: Thierry Volpiatto Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 13 15:43:48 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XznvA-0002FX-56 for ged-emacs-devel@m.gmane.org; Sat, 13 Dec 2014 15:43:48 +0100 Original-Received: from localhost ([::1]:33304 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xznv9-00085A-PY for ged-emacs-devel@m.gmane.org; Sat, 13 Dec 2014 09:43:47 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47710) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xznuq-00084e-0j for emacs-devel@gnu.org; Sat, 13 Dec 2014 09:43:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xznui-0001v3-0f for emacs-devel@gnu.org; Sat, 13 Dec 2014 09:43:27 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:58664) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xznuh-0001ul-Pz for emacs-devel@gnu.org; Sat, 13 Dec 2014 09:43:19 -0500 Original-Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1XznuI-0002FV-9H; Sat, 13 Dec 2014 15:42:54 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAGFBMVEUNCwkGBQUdHBgTExBY TEEPDgwNDAoLCggS0d8wAAACYklEQVQ4jW2TTW/bMAyGiXWWrvMp10Fxtmth1/kBrnYXolK9Cuuk XhUUi//+XtIJ0HUj4sDgo5dfpohTIrVKhUvlyDxPk3MU1GupGSLDJjEsgsC5bqaYcsmVWUC+koYX 0sdsikwWbrtKKHrFY/KmQGq7UrNfNJcJXdFQo6olWsN/F6SCJNlH8TbJ0vRAl6/AbT2owjQ5A7gB 2yCAo9HLxVrUJskllKUO6d++NzM3E6jUwhtYW4eyft+baaKXb+0053ID+K0mNE52/Xrh60wcaWer TENsRwZtaIO26SRsqzLhNQdTNiB1yjDuONVKa+7KOwUsDEvehriB20gs//KM+F1NN4WE/+SXcOcX qsaE/SR+BZmevN97f8g5X/g08snBiJ5JgPeP2SRjuJw4Orc4Ms/WfoZ/j23IFU08Sd+i4EDG+8XP pcgwhpN+WSiKAu9/yCx49AtSQwIFpyJgQTUzD/5RgOxVjfM0IJQ/iAJvk9trKBMjwOD8IzL89FKq 2ztZH1MrqnAePv/gleyRQ4ZqoptHuCSg35Ajltbj/j66ZfBuQBFuA3PImbo58bggdHQ3Q7WBZAE6 VOIOrE2M0vk0HSmgzi461ClglGqxu5G7gCtDANOkiknBEadLOaZU4hxnmZMMRHOopZzeUj0dRvQw uRtIMq/EhQeU7IdlWQREls8cOi6mPDg3DMOoCi9H8KKH35mEwj5YqxfxUvHNJY0M0ej1PK9XcpLj o95zu+7Ou3Pf9ztB9TBvX/AVp/ub7VRUo2ziuvZ/GVgrutR9/5G0Esf/AARTxfkj6AFE8Y+/3wFM 7g+CKvL5kfOt6QAAAABJRU5ErkJggg== X-Now-Playing: Tujoko Noriko's _My Ghost Comes Back_: "Through The Rain" X-Hashcash: 1:23:141213:emacs-devel@gnu.org::l60EAmMs4LJ2tw1k:0000000000000000000000000000000000000000007J8i X-Hashcash: 1:23:141213:thierry.volpiatto@gmail.com::+kaElk/PthbVEIVp:0000000000000000000000000000000000EC0f In-Reply-To: <87d27o80j8.fsf@gmail.com> (Thierry Volpiatto's message of "Sat, 13 Dec 2014 08:35:39 +0100") User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) X-MailScanner-ID: 1XznuI-0002FV-9H MailScanner-NULL-Check: 1419086575.06238@ilNk6cGkuLH2JneeXJ/q5g X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.224.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:180003 Archived-At: Thierry Volpiatto writes: > I am not sure the speed is 10X faster vs directory-files, especially > when sorting the resulting list of `file-name-all-completions'. I benchmarked a bit with # for i in `seq 1 3`; do echo $i > /proc/sys/vm/drop_caches; done in between each run to flush the cache. This is on a machine with an SSD. `file-name-all-completions' version: (benchmark-run 1 (length (directory-files-recursively "~/" "ChangeLog"))) => (38.707872137 204 2.599332819999997) `directory-files' + `file-directory-p' version: (benchmark-run 1 (length (directory-files-recursively-dir "~/" "ChangeLog"))) => (89.957997652 1483 25.952981247000064) So it's faster. The difference is probably more significant on a mechanical disk. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no