From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Magne Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master f2da80d: Ignore invalid base64 encoded embedded images Date: Sun, 20 Mar 2016 16:40:39 +0100 Message-ID: References: <20160320125720.21872.87876@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1458488472 8050 80.91.229.3 (20 Mar 2016 15:41:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 20 Mar 2016 15:41:12 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 20 16:40:59 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ahfTM-0007Lj-O6 for ged-emacs-devel@m.gmane.org; Sun, 20 Mar 2016 16:40:56 +0100 Original-Received: from localhost ([::1]:53386 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahfTI-0003sS-Sr for ged-emacs-devel@m.gmane.org; Sun, 20 Mar 2016 11:40:52 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53879) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahfTF-0003s2-52 for emacs-devel@gnu.org; Sun, 20 Mar 2016 11:40:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ahfTB-0007QB-V6 for emacs-devel@gnu.org; Sun, 20 Mar 2016 11:40:49 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:44741) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahfTB-0007PU-Ou for emacs-devel@gnu.org; Sun, 20 Mar 2016 11:40:45 -0400 Original-Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=stories) by hermes.netfonds.no with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.84_2) (envelope-from ) id 1ahfT5-000339-NM; Sun, 20 Mar 2016 16:40:41 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAHlBMVEX47Oz79PPhkpr9+/o9 MjcGCA6id3zis7fx1Nb1m6VniU0zAAACYUlEQVQ4jXXTz4+aQBQH8EdJuvaGIWm6V9O64QaZJmtv m82A9s54tpYfesNFGbzhgsKZbHXnv+0bcF3bdR8HkvnkO+8NGWBWpQAZZMonIZ67Dzc1X6zs9KYD kxZAvZaQhDWPtw3Mdh71JgC6BG0/PSD4DSRBEEj4gWA93fMGUg3CtFQAXmCPsDgCT1UNNNBvEUhy TFQSuKIpXSAtDHmKEFVmA12ENvEYllVc+Bmv/oPrGcLWy1auBPUVBmlV5Vua/WES8u6p+SCTwCYr BvPDIe9qLRyICQ2MMTEXCPIcTcIyEQo2fqIIYvMKxCw7mHA5l3DWg5gFbmW7kQnGCwwasJYzCdkl UCXcnkA9QjFScarNd1gLESN0jkCKOwn5CtaHdUw0raP/A5tvb2EiQcWEQLBOzUkR6RJ2R7BOiZ0p Qb+SzRcSZPMDQmaRLRvppoRIwamULwg6zovgx6YFCTuvmHQlkKv3YHcBTLL1LsFn21l5pHgDVsEc hqC8gaX700dYIDhOaOOaa7fARhJieODLUeTjGpUsgdktVGVgeq6Ddz45guzxGxLeD1JPVQlJXP8c HvA/CGkY7mKy9BCSFn5BLwh4QIfQ4eR2iOf40MIM+tQJSvsuSkKydVax9bGFIfQSSifemE6GZLFL 4srDwf28cKDvBC71KBuXOn6PDceZ71twKR7BY8OrQRDYeWkz1/DzJQKlNHCo64Ry0Ljzlc5EP38M oW/TgDqUsTHuzqLOWmTr56xMoYclLhSsDZS6NoQhanzwJeq6FgbCdNrf19P5fFqLfS3m095+Xxtz eUsu1rvwFxrNlfMwTUqgAAAAAElFTkSuQmCC In-Reply-To: (Stefan Monnier's message of "Sun, 20 Mar 2016 11:26:56 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.224.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:201942 Archived-At: Stefan Monnier writes: > Hmm... I guess if payload is not a string at all because download > failed, then indeed we have other indications of the problem and > emitting a message would be redundant (and it's a normal occurrence > anyway), but is it really "normal business" for payload to be > a non-base64 string? I thought this would indicate some really > unexpected circumstance. The test case (encountered in the wild) was a base64 string, but it was invalid. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no