From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Lars Ingebrigtsen <larsi@gnus.org>
Newsgroups: gmane.emacs.bugs
Subject: bug#30697: make eval-expression only take `read'-able Lisp,
 bug#30697: make eval-expression only take `read'-able Lisp
Date: Mon, 24 Jun 2019 20:58:23 +0200
Message-ID: <m3o92mq08g.fsf@gnus.org>
References: <m27eqriyat.fsf@aurox.ch> <83k1uru5pc.fsf@gnu.org>
 <m27eqriyat.fsf@aurox.ch>
Mime-Version: 1.0
Content-Type: text/plain
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="197517"; mail-complaints-to="usenet@blaine.gmane.org"
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
Cc: 30697@debbugs.gnu.org
To: charles@aurox.ch (Charles A. Roelli)
Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 24 20:59:14 2019
Return-path: <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>
Envelope-to: geb-bug-gnu-emacs@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.89)
	(envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>)
	id 1hfUBN-000pES-Mm
	for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Jun 2019 20:59:13 +0200
Original-Received: from localhost ([::1]:53952 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.86_2)
	(envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>)
	id 1hfUBM-0001Li-OB
	for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Jun 2019 14:59:12 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40448)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hfUBE-0001Lc-Kw
 for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2019 14:59:06 -0400
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hfUBC-0000eu-Ls
 for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2019 14:59:04 -0400
Original-Received: from debbugs.gnu.org ([209.51.188.43]:44443)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hfUBC-0000eo-HF
 for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2019 14:59:02 -0400
Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hfUBC-0002uG-Dg
 for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2019 14:59:02 -0400
X-Loop: help-debbugs@gnu.org
Resent-From: Lars Ingebrigtsen <larsi@gnus.org>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@gnu.org
Resent-Date: Mon, 24 Jun 2019 18:59:02 +0000
Resent-Message-ID: <handler.30697.B30697.156140271311035@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 30697
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
Original-Received: via spool by 30697-submit@debbugs.gnu.org id=B30697.156140271311035
 (code B ref 30697); Mon, 24 Jun 2019 18:59:02 +0000
Original-Received: (at 30697) by debbugs.gnu.org; 24 Jun 2019 18:58:33 +0000
Original-Received: from localhost ([127.0.0.1]:57987 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1hfUAi-0002rt-BH
 for submit@debbugs.gnu.org; Mon, 24 Jun 2019 14:58:32 -0400
Original-Received: from quimby.gnus.org ([80.91.231.51]:35020)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@gnus.org>) id 1hfUAd-0002rO-Qj
 for 30697@debbugs.gnu.org; Mon, 24 Jun 2019 14:58:28 -0400
Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories)
 by quimby.gnus.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89)
 (envelope-from <larsi@gnus.org>)
 id 1hfUAZ-0006Zn-GT; Mon, 24 Jun 2019 20:58:25 +0200
In-Reply-To: <m27eqriyat.fsf@aurox.ch> (Charles A. Roelli's message of "Sun,
 04 Mar 2018 17:46:18 +0100, Mon, 05 Mar 2018 19:52:14 +0100")
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 209.51.188.43
X-BeenThere: bug-gnu-emacs@gnu.org
List-Id: "Bug reports for GNU Emacs,
 the Swiss army knife of text editors" <bug-gnu-emacs.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-gnu-emacs>
List-Post: <mailto:bug-gnu-emacs@gnu.org>
List-Help: <mailto:bug-gnu-emacs-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=subscribe>
Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org
Original-Sender: "bug-gnu-emacs"
 <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.bugs:161265
Archived-At: <http://permalink.gmane.org/gmane.emacs.bugs/161265>

charles@aurox.ch (Charles A. Roelli) writes:

> Here is a change to make eval-expression issue a warning in the
> minibuffer when the user enters an unreadable expression.  Currently,
> we just error out, so the user has to restart the command and go back
> in the history to get back what he typed.

I think this sounds like a good change -- I often type invalid stuff
into M-: and then have to M-: M-p, so this is a usability win.

>> You are changing the behavior of read--expression, which has a few
>> callers in Emacs.  Did you verify that those callers won't break due
>> to this change?
>
> I've now tested them, and they work fine.  `eval-minibuffer' (which is
> used for (interactive "X")) turns out to be one of the callers of
> `read--expression', so I think the documentation of that interactive
> spec will have to be updated too.
>
> I also did small tests with ido-mode/icomplete-mode enabled, which
> also do not seem to be affected by this change.
>
>> This should also have a NEWS entry, and perhaps the manual needs some
>> changes, please take a look.
>
> Thanks, I will work on that.

Did you finish up the change, Charles?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no