From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.devel Subject: Re: [Proposal] New EUDC backend for macOS address book Date: Wed, 06 May 2020 13:41:11 -0400 Message-ID: References: <8da7df5281e91d8a351f97c0837d79b7@condition-alpha.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="18615"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Jean-Christophe Helary , emacs-devel@gnu.org To: Alexander Adolf Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 06 19:42:01 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jWO3V-0004il-5v for ged-emacs-devel@m.gmane-mx.org; Wed, 06 May 2020 19:42:01 +0200 Original-Received: from localhost ([::1]:49150 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWO3U-0003IC-8E for ged-emacs-devel@m.gmane-mx.org; Wed, 06 May 2020 13:42:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48286) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWO2o-0002bO-L7 for emacs-devel@gnu.org; Wed, 06 May 2020 13:41:18 -0400 Original-Received: from mail-qv1-xf2a.google.com ([2607:f8b0:4864:20::f2a]:36405) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jWO2l-0002dm-Sg for emacs-devel@gnu.org; Wed, 06 May 2020 13:41:18 -0400 Original-Received: by mail-qv1-xf2a.google.com with SMTP id dn1so1193123qvb.3 for ; Wed, 06 May 2020 10:41:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=PphX4PCgKl+BfjavGTviPFM5p1+OdM87K4IagTrRwNc=; b=H4yJjPPDmt3jf0F4tfMtsciEwifrHw5NHL+3wLS8Va5NGj6YBVFnclFq785KF2VWhc xHD+PKDCRmu3JVEmbIovxYj1DyS+0MyRk/wKAKK75Ed4B/cJldcDkVJT3r4R7Ui8tOj3 NSUsrRZNozPAEZu3Ni5cO9PHaoVcZi+lhfnYX3uZTYErbzNr1RQVzfZwiSMZ9U7J9Oub BDwfqSlc1Q42PJDloq5HA3GWsHN5S5ieFUt9RVkDqsRw2iS2+5Pl0UNz5ljfkWL4Holq ruEYTBPZBRLGPxA4dR9jI9uRk5+It219PtRTy2LPM5TNxUYzkPxrGVJoTUuFd5Xe0IJQ zzxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=PphX4PCgKl+BfjavGTviPFM5p1+OdM87K4IagTrRwNc=; b=dLWWXUsHg0f45G31qYhKHlPOWcX7UGUPHmdqrusj7up4fx1/HvaeLDOUltISnKY/KX VznRoOctopwzlWOn7ffXJtVorld2Pan8LeyVrhlClICyRCicqi9wHUkGMB14dXZI2SUe 0uo1PTI6qDXAyyPD2krjNo9VOe9rdItQf3V9MnepX/YLvYZJQnEVz1fQEu5H/qJ30pug nXg38O2W0PhUKw7jgFy8XFPNiwQiGm7KlGj++hmXXL9i93cjPbeQYYemjJ8t4CaJR8BA ninSecgmBYg3zkspg/GZxUOBHmvzQSqCeaJmpOA0w1j576Va71zZKJTA2F4o4mSATiLP ba+Q== X-Gm-Message-State: AGi0PuaKTjJfZisKWv1xy0vb3+F2GwXLp8bnp7QBdsLnIF5pGvTPDDx8 oh4OdP5DLJnUwK0J2fsvQDi8dxH5lN+eMw== X-Google-Smtp-Source: APiQypLFQ+TuIptZvkiVznng90chtQoDSy54cSXDP43qGg34j4UMDCrtu6ewBd/nLb82d9qyX2qO8Q== X-Received: by 2002:ad4:4864:: with SMTP id u4mr8639567qvy.117.1588786873917; Wed, 06 May 2020 10:41:13 -0700 (PDT) Original-Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id q6sm2084620qte.72.2020.05.06.10.41.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 May 2020 10:41:13 -0700 (PDT) In-Reply-To: <8da7df5281e91d8a351f97c0837d79b7@condition-alpha.com> (Alexander Adolf's message of "Wed, 06 May 2020 17:14:59 +0200") Received-SPF: none client-ip=2607:f8b0:4864:20::f2a; envelope-from=fitzsim@fitzsim.org; helo=mail-qv1-xf2a.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:249104 Archived-At: Hi Alexander, Alexander Adolf writes: [...] > Therefore, we can simply use `tell application "Address Book"`, and it > will work on all 10.x macOS-es. OK, that's nice. [...] > I have also folded the lengthy error message line to be below the 80 > limit. Not sure whether this would be considered good practice? Yes, looks good. I noticed one more formatting thing. font-lock is showing "result))))" in red; you can type C-h . to check what the warning is, which in this case is "Hidden behind deeper element; move to another line?". Can you put that on its own line to eliminate the warning? >> Would you be able to write a section in the EUDC manual describing the >> backend and how it relates to eudcb-mab.el? >> >> I don't think it hurts to offer both backends, provided they're >> documented and contrasted in the EUDC manual. > > Yes, I'll be happy to write up a text for the manual. OK, sounds good. [...] > Thanks for these improvements. All applied in the attached, updated > version; except for the last one, which I solved differently. This looks good to go in now. Can you send a draft of the manual change, and then once that's reviewed, I'll have you put it all into one git-format-patch attachment (including the commit log/change log entry) and I can push that to master? Thanks, Thomas