all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [tassilo@member.fsf.org: Weird article scrolling in Gnus with customized face]
@ 2006-10-25 18:02 Richard Stallman
  2006-10-25 19:57 ` Kim F. Storm
  0 siblings, 1 reply; 6+ messages in thread
From: Richard Stallman @ 2006-10-25 18:02 UTC (permalink / raw)


Would someone please fix this and ack?

------- Start of forwarded message -------
Date: Tue, 24 Oct 2006 18:03:21 +0200
From: Tassilo Horn <tassilo@member.fsf.org>
To: emacs-pretest-bug@gnu.org
Subject: Weird article scrolling in Gnus with customized face
X-Spam-Status: No, score=0.1 required=5.0 tests=FORGED_RCVD_HELO 
	autolearn=failed version=3.0.4

Ok, I start up Gnus. Now, if I view an article by hitting RET
(`gnus-summary-scroll-up') on it in *Summary*, I get the following
behavior:

  - as long as there are visible headers (Subject, From, etc.) on top of
    the buffer, pressing RET scrolls exactly one line as it should be.

  - when the last visible header scrolled out of the visible buffer part
    pressing RET results in scrolling one entire page like SPACE
    (`gnus-summary-next-page') does.

  - the same applies to M-RET

I tried it on a test account, and all worked fine. But I was able to
locate the source of the problem: One customized face is causing the
trouble!

(custom-set-faces
 '(mode-line ((((class color) (min-colors 88)) (:background "darkred" :foreground "grey" :box (:line-width 1 :style released-button) :height 0.8 :family "helvetica")))))

If I commend out this line, scrolling works as it should. With this line
I can reproduce the bug in both No Gnus and 5-11.


In GNU Emacs 22.0.50.1 (i686-pc-linux-gnu, GTK+ Version 2.10.6)
 of 2006-10-24 on baldur
X server distributor `The X.Org Foundation', version 11.0.70101000
configured using `configure '--prefix=/usr' '--host=i686-pc-linux-gnu' '--mandir=/usr/share/man' '--infodir=/usr/share/info' '--datadir=/usr/share' '--sysconfdir=/etc' '--localstatedir=/var/lib' '--program-suffix=.emacs-22.0.50' '--without-carbon' '--with-x' '--with-xpm' '--with-toolkit-scroll-bars' '--with-jpeg' '--with-tiff' '--with-gif' '--with-png' '--with-x-toolkit=gtk' '--build=i686-pc-linux-gnu' 'CFLAGS=-O2' 'build_alias=i686-pc-linux-gnu' 'host_alias=i686-pc-linux-gnu''

Important settings:
  value of $LC_ALL: de_DE.utf8
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: de_DE.utf8
  locale-coding-system: utf-8
  default-enable-multibyte-characters: t

Major mode: Emacs-Lisp

Minor modes in effect:
  eldoc-mode: t
  recentf-mode: t
  desktop-save-mode: t
  show-paren-mode: t
  semantic-idle-scheduler-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t
  abbrev-mode: t

Recent input:
y <backspace> n y w a y s . C-x 1 <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <up> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <up> <up> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> C-c C-c y q l s C-x 1 C-x b <right> <return> 
C-x C-s <up> <down> <left> <left> <left> <left> <left> 
M-x e m <tab> <backspace> <backspace> b u g <tab> <backspace> 
<backspace> <backspace> r e p <tab> p <backspace> o 
<tab> r <tab> <tab> b <tab> <return>

Recent messages:
Deleting article /home/heimdall/News/drafts/drafts/3 in drafts...
No more unread newsgroups
Wrote /home/heimdall/.newsrc
Saving /home/heimdall/.newsrc.eld...
Saving file /home/heimdall/.newsrc.eld...
Wrote /home/heimdall/.newsrc.eld
Saving /home/heimdall/.newsrc.eld...done
(No changes need to be saved)
Making completion list... [4 times]
Loading emacsbug...done


_______________________________________________
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
------- End of forwarded message -------

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [tassilo@member.fsf.org: Weird article scrolling in Gnus with customized face]
  2006-10-25 18:02 [tassilo@member.fsf.org: Weird article scrolling in Gnus with customized face] Richard Stallman
@ 2006-10-25 19:57 ` Kim F. Storm
  2006-10-26  8:32   ` Tassilo Horn
  2006-10-26  8:53   ` Richard Stallman
  0 siblings, 2 replies; 6+ messages in thread
From: Kim F. Storm @ 2006-10-25 19:57 UTC (permalink / raw)
  Cc: emacs-devel

Richard Stallman <rms@gnu.org> writes:

> Would someone please fix this and ack?

The problem could be that the last line is only partially visible, and
we have a complex/messy piece of code to handle this in the redisplay
code by recenting point.

If that is the case, I would DEFINITELY NOT try to fix this before the
release, at the risk of making even bigger problems in other cases.

>
> From: Tassilo Horn <tassilo@member.fsf.org>
> Subject: Weird article scrolling in Gnus with customized face
> To: emacs-pretest-bug@gnu.org
> Date: Tue, 24 Oct 2006 18:03:21 +0200
>
> Ok, I start up Gnus. Now, if I view an article by hitting RET
> (`gnus-summary-scroll-up') on it in *Summary*, I get the following
> behavior:
>
>   - as long as there are visible headers (Subject, From, etc.) on top of
>     the buffer, pressing RET scrolls exactly one line as it should be.
>
>   - when the last visible header scrolled out of the visible buffer part
>     pressing RET results in scrolling one entire page like SPACE
>     (`gnus-summary-next-page') does.
>
>   - the same applies to M-RET
>
> I tried it on a test account, and all worked fine. But I was able to
> locate the source of the problem: One customized face is causing the
> trouble!
>
> (custom-set-faces
>  '(mode-line ((((class color) (min-colors 88)) (:background "darkred" :foreground "grey" :box (:line-width 1 :style released-button) :height 0.8 :family "helvetica")))))
>
> If I commend out this line, scrolling works as it should. With this line
> I can reproduce the bug in both No Gnus and 5-11.
>
>
> In GNU Emacs 22.0.50.1 (i686-pc-linux-gnu, GTK+ Version 2.10.6)
>  of 2006-10-24 on baldur
> X server distributor `The X.Org Foundation', version 11.0.70101000
> configured using `configure '--prefix=/usr' '--host=i686-pc-linux-gnu' '--mandir=/usr/share/man' '--infodir=/usr/share/info' '--datadir=/usr/share' '--sysconfdir=/etc' '--localstatedir=/var/lib' '--program-suffix=.emacs-22.0.50' '--without-carbon' '--with-x' '--with-xpm' '--with-toolkit-scroll-bars' '--with-jpeg' '--with-tiff' '--with-gif' '--with-png' '--with-x-toolkit=gtk' '--build=i686-pc-linux-gnu' 'CFLAGS=-O2' 'build_alias=i686-pc-linux-gnu' 'host_alias=i686-pc-linux-gnu''
>
> Important settings:
>   value of $LC_ALL: de_DE.utf8
>   value of $LC_COLLATE: nil
>   value of $LC_CTYPE: nil
>   value of $LC_MESSAGES: nil
>   value of $LC_MONETARY: nil
>   value of $LC_NUMERIC: nil
>   value of $LC_TIME: nil
>   value of $LANG: de_DE.utf8
>   locale-coding-system: utf-8
>   default-enable-multibyte-characters: t
>
> Major mode: Emacs-Lisp
>
> Minor modes in effect:
>   eldoc-mode: t
>   recentf-mode: t
>   desktop-save-mode: t
>   show-paren-mode: t
>   semantic-idle-scheduler-mode: t
>   tooltip-mode: t
>   mouse-wheel-mode: t
>   menu-bar-mode: t
>   file-name-shadow-mode: t
>   global-font-lock-mode: t
>   font-lock-mode: t
>   unify-8859-on-encoding-mode: t
>   utf-translate-cjk-mode: t
>   auto-compression-mode: t
>   column-number-mode: t
>   line-number-mode: t
>   transient-mark-mode: t
>   abbrev-mode: t
>
> Recent input:
> y <backspace> n y w a y s . C-x 1 <up> <up> <up> <up> 
> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
> <up> <up> <up> <down> <down> <down> <down> <down> <down> 
> <down> <down> <down> <down> <up> <up> <down> <down> 
> <down> <down> <down> <down> <down> <down> <down> <down> 
> <down> C-c C-c y q l s C-x 1 C-x b <right> <return> 
> C-x C-s <up> <down> <left> <left> <left> <left> <left> 
> M-x e m <tab> <backspace> <backspace> b u g <tab> <backspace> 
> <backspace> <backspace> r e p <tab> p <backspace> o 
> <tab> r <tab> <tab> b <tab> <return>
>
> Recent messages:
> Deleting article /home/heimdall/News/drafts/drafts/3 in drafts...
> No more unread newsgroups
> Wrote /home/heimdall/.newsrc
> Saving /home/heimdall/.newsrc.eld...
> Saving file /home/heimdall/.newsrc.eld...
> Wrote /home/heimdall/.newsrc.eld
> Saving /home/heimdall/.newsrc.eld...done
> (No changes need to be saved)
> Making completion list... [4 times]
> Loading emacsbug...done
>
>
> _______________________________________________
> emacs-pretest-bug mailing list
> emacs-pretest-bug@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
> ----------
>

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [tassilo@member.fsf.org: Weird article scrolling in Gnus with customized face]
  2006-10-25 19:57 ` Kim F. Storm
@ 2006-10-26  8:32   ` Tassilo Horn
  2006-10-26  8:53   ` Richard Stallman
  1 sibling, 0 replies; 6+ messages in thread
From: Tassilo Horn @ 2006-10-26  8:32 UTC (permalink / raw)


storm@cua.dk (Kim F. Storm) writes:

Hi all,

I could isolate the problem even better:

>> (custom-set-faces '(mode-line ((((class color) (min-colors 88))
>> (:background "darkred" :foreground "grey" 
>> :box (:line-width 1 :style released-button) :height 0.8 :family
         ^^^^^^^^^^^^^
If I set :line-width to -1 (the default value), scrolling works as
expected.

>> "helvetica")))))

Regards,
Tassilo
-- 
My opinions may have changed, but not the fact that I am right.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [tassilo@member.fsf.org: Weird article scrolling in Gnus with customized face]
  2006-10-25 19:57 ` Kim F. Storm
  2006-10-26  8:32   ` Tassilo Horn
@ 2006-10-26  8:53   ` Richard Stallman
  2006-10-26 21:24     ` Kim F. Storm
  1 sibling, 1 reply; 6+ messages in thread
From: Richard Stallman @ 2006-10-26  8:53 UTC (permalink / raw)
  Cc: emacs-devel

    The problem could be that the last line is only partially visible, and
    we have a complex/messy piece of code to handle this in the redisplay
    code by recenting point.

It sounds plausible.

How about if you look for some obvious straightforward bug,
and if you find one and you see a safe fix, install that.
Otherwise add a comment saying "fixme" with a description of
the case that fails.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [tassilo@member.fsf.org: Weird article scrolling in Gnus with customized face]
  2006-10-26  8:53   ` Richard Stallman
@ 2006-10-26 21:24     ` Kim F. Storm
  2006-10-27 13:32       ` Richard Stallman
  0 siblings, 1 reply; 6+ messages in thread
From: Kim F. Storm @ 2006-10-26 21:24 UTC (permalink / raw)
  Cc: emacs-devel

Richard Stallman <rms@gnu.org> writes:

>     The problem could be that the last line is only partially visible, and
>     we have a complex/messy piece of code to handle this in the redisplay
>     code by recenting point.
>
> It sounds plausible.
>
> How about if you look for some obvious straightforward bug,
> and if you find one and you see a safe fix, install that.

I don't have time to debug it now.

> Otherwise add a comment saying "fixme" with a description of
> the case that fails.

Can't we just remember the bug and work on it after the release...

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [tassilo@member.fsf.org: Weird article scrolling in Gnus with customized face]
  2006-10-26 21:24     ` Kim F. Storm
@ 2006-10-27 13:32       ` Richard Stallman
  0 siblings, 0 replies; 6+ messages in thread
From: Richard Stallman @ 2006-10-27 13:32 UTC (permalink / raw)
  Cc: emacs-devel

    > Otherwise add a comment saying "fixme" with a description of
    > the case that fails.

    Can't we just remember the bug and work on it after the release...

Memory is not so reliable -- would you please add a "fixme" comment
with a description of the test case, or a reference to the message?
That will help us remember.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2006-10-27 13:32 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-25 18:02 [tassilo@member.fsf.org: Weird article scrolling in Gnus with customized face] Richard Stallman
2006-10-25 19:57 ` Kim F. Storm
2006-10-26  8:32   ` Tassilo Horn
2006-10-26  8:53   ` Richard Stallman
2006-10-26 21:24     ` Kim F. Storm
2006-10-27 13:32       ` Richard Stallman

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.