From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: cannot understand Elisp manual node Glyphs Date: Fri, 09 Feb 2007 12:12:46 +0100 Message-ID: References: <87y7n9ins4.fsf@catnip.gol.com> <864ppxhw0l.fsf@lola.quinscape.zz> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1171019557 30946 80.91.229.12 (9 Feb 2007 11:12:37 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 9 Feb 2007 11:12:37 +0000 (UTC) Cc: miles@gnu.org, drew.adams@oracle.com, emacs-devel@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 09 12:12:29 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HFTg3-0003mB-MD for ged-emacs-devel@m.gmane.org; Fri, 09 Feb 2007 12:12:27 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HFTg3-0002FE-2P for ged-emacs-devel@m.gmane.org; Fri, 09 Feb 2007 06:12:27 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HFTfs-0002E6-70 for emacs-devel@gnu.org; Fri, 09 Feb 2007 06:12:16 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HFTfq-0002Db-RW for emacs-devel@gnu.org; Fri, 09 Feb 2007 06:12:15 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HFTfq-0002DP-Ji for emacs-devel@gnu.org; Fri, 09 Feb 2007 06:12:14 -0500 Original-Received: from pfepc.post.tele.dk ([195.41.46.237]) by monty-python.gnu.org with esmtp (Exim 4.52) id 1HFTfn-0001CJ-6Y; Fri, 09 Feb 2007 06:12:11 -0500 Original-Received: from kfs-l.imdomain.dk.cua.dk (unknown [80.165.4.124]) by pfepc.post.tele.dk (Postfix) with SMTP id 09F968A0010; Fri, 9 Feb 2007 12:12:08 +0100 (CET) In-Reply-To: (Richard Stallman's message of "Thu\, 08 Feb 2007 18\:46\:08 -0500") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.93 (gnu/linux) X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:66156 Archived-At: Richard Stallman writes: > Please do NOT add a function make-glyph-code now. > This is not the time for new features. The initial reason behind this change was to improve _documentation_, for an _existing_ feature which is definitely non-obvious, and basically has no clean API (or an API at all). In fact, I have code which I wrote for Emacs 19 / Emacs 20, which stopped working in Emacs 21 because the encoding of faces in glyph codes changed ... IMO, it is a very bad API design to force Lisp code to relying on internal numeric constants, which have already changed once between Emacs releases. AND IT WILL CHANGE AGAIN IN EMACS 23 (using 22 bits instead of 19). So if _this_ is not the right time for cleaning up this mess, I don't know when is!! BTW, the unicode-2 branch seems to have bugs in this area, exactly because the changes to this encoding at the C-leve are not reflected in the Lisp code. My patch would fix those bugs too (with the obvious changes to the new functions) in Emacs 23 too. Furthermore, the unicode branch only allows the first 511 faces defined to be used in glyph-code (vs. 4088 in Emacs 22) ... so maybe the whole implementation of glyph-codes need to be revised in Emacs 23 -- yet another reason for making a clean interface for this NOW. WDOT ?? -- Kim F. Storm http://www.cua.dk