Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Your patch needs a few tweaks, e.g. to adjust it to the coding
> conventions:
> - The docstring of window-parameters is poor.
>   E.g. the first line doesn't say anything.  The second line is indented
>   in the source, which looks bad when you do C-h f window-parameters.
>   nil is an aliast as well, so there's no need to mention it explicitly.
> - I'd prefer to have `window-parameter' rather than `window-parameters'.
> - The docstring of set-window-parameter needs to start with a capital
>   letter and end with a "." and should mention its arguments.
>   Feel free to plagiarize set-frame-parameter.
> - The comment for window_parameters refers to `pin' and `group'.
> - See http://www.gnu.org/prep/standards/standards.html#Change-Logs for
>   the format to use in ChangeLogs:
>   - put together changes to a file.
>   - your changelog seems to say you've changed `DEFUN'.
>   - there's a missing space after colon in "(window:Added".
>   - And the "Added" should be "Add" of course.

I've tried to adress your concerns in the attached patch.

A reworked ChangeLog entry:

2008-06-03  Joakim Verona  <joakim@verona.se>

	* window.h (window_parameters): Declare

	* window.c: (Fwindow_parameters): New defun.
	(Fwindow_parameter): New defun.
	(Fset_window_parameter): New defun.
	(syms_of_window): Defsubr the new defuns.
	(make_window): 	initialize window_parameters to nil