From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daiki Ueno Newsgroups: gmane.emacs.bugs Subject: bug#22440: 25.1.50; package.el fails to install with package-check-signature t Date: Thu, 19 May 2016 10:30:08 +0900 Message-ID: References: <87a8nxxgqu.fsf@udel.edu> <57381F2D.70007@cs.ucla.edu> <3ea72c05-4bdb-3301-aead-ea7eb25947bc@yandex.ru> <5738A8D5.5030206@cs.ucla.edu> <1fe8c642-202d-a037-5125-8fb733e5f414@yandex.ru> <20160518164405.GA9932@holos.localdomain> <87vb2b6ufy.fsf@gmail.com> <87k2ir6u1b.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1463621487 19893 80.91.229.3 (19 May 2016 01:31:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 19 May 2016 01:31:27 +0000 (UTC) Cc: Mark Oteiza , Paul Eggert , 22440@debbugs.gnu.org, Dmitry Gutov To: Artur Malabarba Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 19 03:31:16 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b3Cnz-0000Do-2H for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 May 2016 03:31:15 +0200 Original-Received: from localhost ([::1]:47688 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3Cnv-000368-5p for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 May 2016 21:31:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39970) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3Cnp-00035y-Df for bug-gnu-emacs@gnu.org; Wed, 18 May 2016 21:31:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b3Cnm-0005dy-6d for bug-gnu-emacs@gnu.org; Wed, 18 May 2016 21:31:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45123) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3Cnm-0005du-3O for bug-gnu-emacs@gnu.org; Wed, 18 May 2016 21:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b3Cnl-0005Mi-S2 for bug-gnu-emacs@gnu.org; Wed, 18 May 2016 21:31:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daiki Ueno Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 May 2016 01:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22440 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: security Original-Received: via spool by 22440-submit@debbugs.gnu.org id=B22440.146362142620577 (code B ref 22440); Thu, 19 May 2016 01:31:01 +0000 Original-Received: (at 22440) by debbugs.gnu.org; 19 May 2016 01:30:26 +0000 Original-Received: from localhost ([127.0.0.1]:57460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b3CnC-0005Lp-8W for submit@debbugs.gnu.org; Wed, 18 May 2016 21:30:26 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:48909) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b3CnB-0005Ld-FY for 22440@debbugs.gnu.org; Wed, 18 May 2016 21:30:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b3Cn3-0005Uu-5L for 22440@debbugs.gnu.org; Wed, 18 May 2016 21:30:20 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54343) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3Cn3-0005Um-1y; Wed, 18 May 2016 21:30:17 -0400 Original-Received: from du-a.org ([219.94.251.20]:38418 helo=localhost.localdomain) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1b3Cn1-0003TE-4n; Wed, 18 May 2016 21:30:15 -0400 In-Reply-To: <87k2ir6u1b.fsf@gmail.com> (Artur Malabarba's message of "Wed, 18 May 2016 16:33:04 -0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118435 Archived-At: Artur Malabarba writes: > Here's a proposed fix. Thank you for taking a look at this, the patch looks good to me. > ;;;###autoload > @@ -1558,12 +1558,8 @@ package-refresh-contents > (let ((default-keyring (expand-file-name "package-keyring.gpg" > data-directory)) > (inhibit-message async)) > - (if (get 'package-check-signature 'saved-value) > - (when package-check-signature > - (epg-find-configuration 'OpenPGP)) > - (setq package-check-signature > - (if (epg-find-configuration 'OpenPGP) > - 'allow-unsigned))) > + (when package-check-signature > + (epg-find-configuration 'OpenPGP)) While it was from the original code, I would suggest to check the return value of `epg-find-configuration' or simply remove this `when' clause. Regards, -- Daiki Ueno